Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add confidence_float to actions table #1008

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Oct 18, 2024

Important

Add confidence_float column to actions table and update related model and function to handle it.

  • Database Schema:
    • Add confidence_float column to actions table in 2873c5c8c41e_add_actions_confidence_float.py.
    • Update ActionModel in models.py to include confidence_float as a Numeric column.
  • Functionality:
    • Modify create_action in client.py to set confidence_float when creating a new action.

This description was created by Ellipsis for def8a22. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to def8a22 in 29 seconds

More details
  • Looked at 63 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. alembic/versions/2024_10_18_2003-2873c5c8c41e_add_actions_confidence_float.py:24
  • Draft comment:
    Consider specifying precision and scale for the confidence_float column to ensure it meets the application's requirements.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds a new column confidence_float to the actions table. The column is defined as Numeric, which is appropriate for a float value. However, the precision and scale are not specified, which might lead to unexpected behavior if the default precision and scale are not suitable for the application's needs.

Workflow ID: wflow_LBtRALpxmcslqgfg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit b31b777 into main Oct 20, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/add_confidence_floa_to_action branch October 20, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant