Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make secret key placeholder more clear #1001

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Oct 18, 2024

Important

Replaced default SECRET_KEY and SKYVERN_API_KEY with "PLACEHOLDER" in config.py.

  • Configuration Changes:
    • Replaced default SECRET_KEY with "PLACEHOLDER" in Settings class in config.py.
    • Replaced default SKYVERN_API_KEY with "PLACEHOLDER" in Settings class in config.py.

This description was created by Ellipsis for 55b39c0. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 55b39c0 in 9 seconds

More details
  • Looked at 19 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/config.py:39
  • Draft comment:
    Consider adding a comment to remind developers to replace 'PLACEHOLDER' with a secure key in production.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the default values of sensitive keys to 'PLACEHOLDER', which is a good practice for security. However, it would be better to add a comment to remind developers to replace these placeholders with actual secure values in production.

Workflow ID: wflow_V2WM4mdjjQqAUUyu


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 4b7a4ed into main Oct 18, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/make_secret_a_placeholder branch October 18, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant