Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling for 304 not modified responses #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joesarre
Copy link

Added a fix for response = None

@ardydedase
Copy link
Contributor

Hi @joesarre,

Unit tests are broken for this pull request: https://travis-ci.org/Skyscanner/skyscanner-python-sdk/builds/81211741 and coverage have decreased.

Looks like we'll need to update the unit tests for this pull request.

Thanks,
Ardy

@joesarre
Copy link
Author

Cheers, yeah I'll have another go at it when I can. I think the tests are
failing because of the rate limit, but agree on coverage. Hard to test for
as that code path requires the underlying API to return a 304 which only
happens occasionally. I stopped short of introducing mocks into the tests.
On 19 Sep 2015 21:47, "Ardy Dedase" [email protected] wrote:

Hi @joesarre https://github.com/joesarre,

Unit tests are broken for this pull request:
https://travis-ci.org/Skyscanner/skyscanner-python-sdk/builds/81211741
and coverage have decreased.

Looks like we'll need to update the unit tests for this pull request.

Thanks,
Ardy


Reply to this email directly or view it on GitHub
#11 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants