Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout to version and banner checks #550

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Add timeout to version and banner checks #550

merged 2 commits into from
Oct 31, 2024

Conversation

Frostbyte0x70
Copy link
Member

Originally reported at: https://discord.com/channels/710190644152369162/1301663321036161117
SkyTemple hangs if it cannot connect to release.skytemple.org

@github-actions GitHub Actions
Copy link

Test Results

    14 files  ±0      14 suites  ±0   48m 3s ⏱️ - 5m 19s
10 901 tests ±0  10 900 ✅ ±0      1 💤 ±0  0 ❌ ±0 
32 904 runs  ±0  26 132 ✅ ±0  6 772 💤 ±0  0 ❌ ±0 

Results for commit 5a5986c. ± Comparison against base commit 382e530.

theCapypara
theCapypara approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@theCapypara theCapypara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@theCapypara theCapypara merged commit 10b7fa7 into SkyTemple:master Oct 31, 2024
24 checks passed
@Frostbyte0x70 Frostbyte0x70 deleted the add-timeout branch November 1, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theCapypara theCapypara theCapypara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Frostbyte0x70 @theCapypara