Add timeout to version and banner checks

SkyTemple · Oct 31, 2024 · efcc863 · efcc863
1 parent 382e530
commit efcc863
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/skytemple_files/common/version_util.py b/skytemple_files/common/version_util.py
@@ -23,6 +23,7 @@
 RELEASE_WEB = "https://release.skytemple.org/"
 BANNER_LINK = "banner"
 BANNER_IMG = "banner.png"
+CONNECTION_TIMEOUT = 4
 
 
 class ReleaseType(Enum):
@@ -35,13 +36,16 @@ def check_newest_release(rtype: ReleaseType) -> str:
     Returns the newest release using release.skytemple.org.
     May fail if no connection can be established!
     """
-    return urllib.request.urlopen(RELEASE_WEB + rtype.value, context=create_context()).read().decode("utf-8").strip()
+    return (urllib.request.urlopen(RELEASE_WEB + rtype.value, context=create_context(), timeout=CONNECTION_TIMEOUT)
+            .read().decode("utf-8").strip())
 
 
 def get_event_banner() -> tuple[bytes | None, str | None]:
     try:
-        url = urllib.request.urlopen(RELEASE_WEB + BANNER_LINK, context=create_context()).read().decode("utf-8").strip()
-        img = urllib.request.urlopen(RELEASE_WEB + BANNER_IMG, context=create_context()).read()
+        url = (urllib.request.urlopen(RELEASE_WEB + BANNER_LINK, context=create_context(), timeout=CONNECTION_TIMEOUT)
+               .read().decode("utf-8").strip())
+        img = (urllib.request.urlopen(RELEASE_WEB + BANNER_IMG, context=create_context(), timeout=CONNECTION_TIMEOUT)
+               .read())
         return img, url
     except Exception:
         return None, None