Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Truncation in Timespan Tabulation #7646

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

sovdeeth
Copy link
Member

Description

Does as much math in doubles as possible before clamping to long when creating the timespan.


Target Minecraft Versions: any
Requirements: none
Related Issues: #7645

@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Feb 25, 2025
@erenkarakal
Copy link
Member

executing 'send 5 seconds / 0'
292471208 years and 8 months and 1 week and 7 hours and 12 minutes and 55.81 seconds

@Jjman739
Copy link

executing 'send 5 seconds / 0'
292471208 years and 8 months and 1 week and 7 hours and 12 minutes and 55.81 seconds

Seems in line with existing behavior.

executing 'message 1/0'
Infinity

@erenkarakal erenkarakal added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Feb 25, 2025
@sovdeeth sovdeeth merged commit c000483 into SkriptLang:dev/patch Feb 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants