Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node js package and GitHub actions #5180

Closed
wants to merge 2 commits into from
Closed

Add node js package and GitHub actions #5180

wants to merge 2 commits into from

Conversation

TheLimeGlass
Copy link
Contributor

Description

We need to fix GitHub actions running on a node.js branch, also add tests for CI. Ali's pull at #4319 doesn't have this so it shouldn't conflict.

@AyhamAl-Ali AyhamAl-Ali added the documentation Related to Skript's official documentation. label Oct 25, 2022
Moderocky
Moderocky reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we're using any node JS build scripts/container themes on the website - Ayham made the style himself.

@TheLimeGlass
Copy link
Contributor Author

It also prevents GitHub actions from stall idling like this, as it has a task to represent it.

@Pikachu920 Pikachu920 added the hacktoberfest-accepted Marks a PR as accepted for Hacktoberfest label Oct 27, 2022
AyhamAl-Ali
AyhamAl-Ali requested changes Nov 11, 2022
View reviewed changes
package.json
@@ -0,0 +1,19 @@
{
"name": "skript",
"version": "1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version would this follow Skript or the website? for the website currently the version is handled here
In case it doesn't show up from the link
image

APickledWalrus
APickledWalrus approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be okay (approval from ayham def needed)

Maybe the workflow should target all branches so that it runs on PRs too?
This workflow will only be present on gh-pages affiliated branches so.

@TPGamesNL TPGamesNL removed the hacktoberfest-accepted Marks a PR as accepted for Hacktoberfest label Dec 26, 2022
@TheLimeGlass
Copy link
Contributor Author

Going to rebase this on the documentation repo

@TheLimeGlass TheLimeGlass deleted the branch gh-pages February 16, 2023 13:56
@TheLimeGlass TheLimeGlass self-assigned this Feb 16, 2023
@TheLimeGlass TheLimeGlass deleted the feature/docs-actions branch February 16, 2023 13:59
@TheLimeGlass TheLimeGlass removed their assignment Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moderocky Moderocky Moderocky left review comments

@AyhamAl-Ali AyhamAl-Ali AyhamAl-Ali requested changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

Assignees
No one assigned
Labels
documentation Related to Skript's official documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TheLimeGlass @Moderocky @AyhamAl-Ali @APickledWalrus @Pikachu920 @TPGamesNL