Fix certificate generation and validation #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2024
Sjors
force-pushed
the
2023/11/sv2-poll
branch
2 times, most recently
from
aa952cb
to
d5d9695
Compare
Sjors
force-pushed
the
2024/01/sv2-cert-fix
branch
from
9c387e2
to
7f32151
Compare
Sjors
force-pushed
the
2023/11/sv2-poll
branch
from
d5d9695
to
2a9f7d1
Compare
Sjors
force-pushed
the
2024/01/sv2-cert-fix
branch
from
7f32151
to
8faaf56
Compare
Sjors
force-pushed
the
2023/11/sv2-poll
branch
from
2a9f7d1
to
d4d3dad
Compare
Sjors
force-pushed
the
2024/01/sv2-cert-fix
branch
2 times, most recently
from
54dca65
to
c7942d3
Compare
Sjors
force-pushed
the
2023/11/sv2-poll
branch
2 times, most recently
from
f00b310
to
3bb4604
Compare
Sjors
force-pushed
the
2024/01/sv2-cert-fix
branch
from
c7942d3
to
88651ee
Compare
Sjors
force-pushed
the
2023/11/sv2-poll
branch
from
3bb4604
to
cfbdf2b
Compare
* include m_static_key in the hash that's signed * sign using the authority key
Sjors
force-pushed
the
2024/01/sv2-cert-fix
branch
from
88651ee
to
ceec439
Compare
This was referenced Jan 22, 2024
Closed
|
I included this into the main PR, with a revert commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires SRI to be fixed at the same time, see stratum-mining/stratum#717
The relevant commit is "Fix certificate generation and validation". I'll occasionally rebase this PR so it's the only commit.