Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Silex updrage compatibility #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

williamespindola
Copy link

@williamespindola williamespindola commented Nov 22, 2016

Upgrade silex to 2.0
issue #2

Upgrade silex to 2.0

$app->register(new RabbitServiceProvider(), [
$container['debug'] = function() {
return true;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot this I think

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mock for tests, without this tests will not pass because doesn't exists debug function on container.

@mathroc
Copy link

mathroc commented Nov 30, 2016

what about having pimple/pimple ^3.0 as a dependency and Silex as a suggestion ? I have not reviewed the code extensively but I don't think Silex is needed anymore

@williamespindola
Copy link
Author

This sounds good. But we will need to implement Console components directly that sounds good too.

@williamespindola
Copy link
Author

But if your PR #4 is approved this dependency is a suggestion too.

@williamespindola
Copy link
Author

ping

@AntonStoeckl
Copy link

Sorry for the late reply!
For a number of reasons, job and family related, I can't maintain this any more. :-(
I have abandoned the package on Packagist.
If anybody wants to fork and take over I can point to the replacement on Packagist.

@williamespindola
Copy link
Author

@AntonStoeckl please update readme with link of my repository https://github.com/williamespindola/rabbitmq-service-provider

@AntonStoeckl
Copy link

@williamespindola
Will do in a minute.
Do you already have a package @ Packagist?

@williamespindola
Copy link
Author

Yes! Packagist is set up

@AntonStoeckl
Copy link

I have suggested your package as replacement.
Please note that there are two other version there, maybe you want to join forces with one of them:
https://packagist.org/packages/sylwit/rabbitmq-service-provider
https://packagist.org/packages/exs/silex-rabbitmq-provider

@williamespindola
Copy link
Author

That's good! Thanks for the job.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants