Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setters of p0c and delta to update _rvv and zeta #57

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roman-martin
Copy link

Fix for issue #55

However, I am not 100% pleased with the current status:

  • For one, I am not sure if there are other parameters to be updated as well (_rpp?).
  • The next problem is that _update_particles_from_absolute() is now updating zeta, but relatively, not from absolute like the function name suggests... we might want to create a differently named function for that?
  • Lastly the delta.setter now has to check whether the attribute _rvv already exists (as it is also used during initialization) in order to update zeta. Again we might want to change the program flow a bit more here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant