-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QuadDistortion to ProjectiveTransformBuilder #2748
Conversation
|
Thanks @Socolin for this, it is very interesting! I'll have to put my math's hat on to look at this. I'm curious. Is this potentially an alternative (better) approach to |
FYI: The performance test I did TestPerformanceGaussianElimination.zip
|
@Socolin I'll see if I can find some time over the next few days to pull down your fork and help reimplement it into the latest codebase. I'm keen to add this functionality. |
I finally have some time again. |
I rebased the branch and pushed the changes |
I just saw I'm getting an error because |
The operation takes nanoseconds so I'm not concerned by that. |
Hi @Socolin would it be possible for you to give me full write access to your fork so I can complete this PR for you? There's a known issue with Git LFS and GitHub which means I cannot update the reference images without full write access. Thanks! |
I did grant you access to the repo, can you confirm it's all right ? |
Perfect. Thank you! |
I think this is good to go now. Thanks @Socolin for submitting the solution for this. It's a fantastic addition to the library! |
Prerequisites
Description
Add 2 new methods:
PrependQuadDistortion
andAppendQuadDistortion
toProjectiveTransformBuilder
.Those method allow to apply a distortion on an image by specifying the requested coordinate for each corner.
Example:
Source
Result