Feature: Added S3ClientProvider to AWSS3StorageCache and AWSS3StorageImageProvider #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklagendijk
commented
Mar 15, 2024
| S3CannedACL acl) | ||
| => AsyncHelper.RunSync(() => CreateIfNotExistsAsync(options, acl)); | ||
| S3CannedACL acl, | ||
| IServiceProvider serviceProvider) |
There was a problem hiding this comment.
This change is a breaking change, because it requires users of this method to add the serviceProvider param.
marklagendijk
commented
Mar 15, 2024
| namespace SixLabors.ImageSharp.Web; | ||
|
|
||
| /// <summary> | ||
| /// Provides a common interface for AWS S3 Bucket Client Options. | ||
| /// </summary> | ||
| internal interface IAWSS3BucketClientOptions | ||
| public interface IAWSS3BucketClientOptions |
There was a problem hiding this comment.
I had to make the internal interface public here, because it is used as a param of the S3ClientProvider.
|
@marklagendijk We've got failing tests here. Could you please have a look? |
|
I want to avoid breaking changes here or else it's major version update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Implementation of #360 for AWS.