Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading on servers #1419

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Fix loading on servers #1419

merged 2 commits into from
Sep 22, 2024

Conversation

dima-dencep
Copy link
Contributor

@dima-dencep dima-dencep commented Sep 15, 2024

The Issue

The connector prevents the server from starting

The Proposal

Fix the issue above

@Su5eD Su5eD self-assigned this Sep 15, 2024
@Su5eD Su5eD added bug Something isn't working 1.21.x Targets Minecraft 1.21 labels Sep 15, 2024
@Su5eD
Copy link
Member

Su5eD commented Sep 16, 2024

Have you tested this? I'm getting the following error when running on a neoforge 21.1.51 dedicated server

Exception message: java.lang.NullPointerException: Cannot invoke "java.util.List.size()" because the return value of "net.neoforged.neoforge.registries.DataPackRegistriesHooks.getDataPackRegistries()" is null

@Su5eD Su5eD added the needs info Further information is requested label Sep 17, 2024
@dima-dencep
Copy link
Contributor Author

Have you tested this?

Of course
https://mclo.gs/AqxBxY0

@Mattabase
Copy link

Have you tested this?

Of course https://mclo.gs/AqxBxY0

I am getting the same error as Su5eD when running on a neoforge 21.1.51 dedicated serve

@dima-dencep
Copy link
Contributor Author

I don't get this error

@dima-dencep
Copy link
Contributor Author

I don't know, maybe OS is the reason?

@wc7086
Copy link

wc7086 commented Sep 22, 2024

@dima-dencep Can you give me a copy of the binary file?

@dima-dencep
Copy link
Contributor Author

Compile it yourself

@wc7086

This comment was marked as off-topic.

@Su5eD
Copy link
Member

Su5eD commented Sep 22, 2024

**** FAILED TO BIND TO PORT!
Perhaps a server is already running on that port?

This seems like an unrelated issue

@wc7086
Copy link

wc7086 commented Sep 22, 2024

**** FAILED TO BIND TO PORT!
Perhaps a server is already running on that port?

This seems like an unrelated issue

Sorry, because I don't have online-mode enabled there is always a warning that I subconsciously ignore.

@Su5eD Su5eD merged commit b3ab92a into Sinytra:dev Sep 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.x Targets Minecraft 1.21 bug Something isn't working needs info Further information is requested
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants