Fix Ubuntu Installation #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't the case as stated in https://forum.sinusbot.com/threads/upcoming-changes.8659
Added additional install of `python-is-python3` when using debian
As per talk with flyth, we don't need it anymore, due to removal of the license system
Raise debian version to 10+ Raise ubuntu version to 18.04+ Fix casing for brand name TeamSpeak
|
Merge #100 before this |
commit f4f8bc8 Author: Lala Sabathil <[email protected]> Date: Thu Oct 6 10:33:35 2022 +0200 Update test commit 3df4402 Author: Lala Sabathil <[email protected]> Date: Thu Oct 6 09:27:54 2022 +0200 Rework startup_test commit fd2f750 Author: Lala Sabathil <[email protected]> Date: Wed Oct 5 19:33:01 2022 +0200 [ci skip] apply code review commit cbd3af4 Author: Lala Sabathil <[email protected]> Date: Wed Oct 5 19:30:53 2022 +0200 Apply suggestions from code review Co-authored-by: Max Schmitt <[email protected]> commit 8bdb446 Author: Lala Sabathil <[email protected]> Date: Wed Oct 5 19:11:38 2022 +0200 chore: update ci badge commit 7e47dd8 Author: Lala Sabathil <[email protected]> Date: Wed Oct 5 18:58:34 2022 +0200 devops: Imrpove testing chore: add discord test chore: despawn instances after test
We need to ensure the discord bot token isn't used at the same time. This increases time, but is safer
|
Still doesn't work on Ubuntu 22.04 (image from http://download.proxmox.com/images/system/ubuntu-22.04-standard_22.04-1_amd64.tar.zst, OpenVZ): I need to Another error:
|
Lulalaby
commented
Jan 14, 2023
Comment on lines
+617
to
+619
| if [[ $(cat /etc/*release | grep "PRETTY_NAME=" | sed 's/PRETTY_NAME=//g') =~ "Debian" ]]; then | ||
| apt-get install -y -qq --no-install-recommends python-is-python3 | ||
| fi |
There was a problem hiding this comment.
Suggested change
| if [[ $(cat /etc/*release | grep "PRETTY_NAME=" | sed 's/PRETTY_NAME=//g') =~ "Debian" ]]; then | |
| apt-get install -y -qq --no-install-recommends python-is-python3 | |
| fi | |
| if [[ $(cat /etc/*release | grep "PRETTY_NAME=" | sed 's/PRETTY_NAME=//g') =~ "Debian" ]]; then | |
| apt-get install -y -qq --no-install-recommends python-is-python3 | |
| fi | |
| if [[ $(cat /etc/*release | grep "PRETTY_NAME=" | sed 's/PRETTY_NAME=//g') =~ "Ubuntu" ]]; then | |
| apt-get install -y -qq --no-install-recommends python-is-python3 | |
| fi |
There was a problem hiding this comment.
mhh have to filter for old ubuntu version
|
tbh I don't think i can fix this. Sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #97
Closes: #91
Closes: #82
Closes: #81
Follow-up of #98, by request of @mxschmitt