-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/save charts with User Defined Path #316
Feature/save charts with User Defined Path #316
Conversation
…ature/vertexai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I reviewed the save_charts
related features and had a couple thoughts.
.gitignore
Outdated
.vscode | ||
|
||
/exports/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exports/
can already be found on line 34.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. However, it was not working for my Directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's surprising. It's formatted according to the docs: https://git-scm.com/docs/gitignore
1. Ran `black` and pre-commit 2. Fixed .gitignore 3. added `pandasai.__version__` : Reading version from `pyproject.toml` file
@jonbiemond addressed all your concerns.
|
PR related to #271 . Below is the example to use.