Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/support chinese in prompt generation #1317

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Fix/support chinese in prompt generation #1317

merged 2 commits into from
Oct 16, 2024

Conversation

cFireworks
Copy link
Contributor

@cFireworks cFireworks commented Aug 8, 2024 •
edited
Loading

@cFireworks
Update dataframe_serializer.py
456ff73 
fix Sinaptik-AI#1168 Support Chinese characters in prompt generation stage
@cFireworks
fix: Support Chinese characters in prompt generation stage (Sinaptik-…
cd3bf42 
…AI#1168)

Update dataframe_serializer.py
add test case to Sinaptik-AI#1168
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 8, 2024
@cFireworks cFireworks closed this Aug 8, 2024
@cFireworks cFireworks reopened this Aug 8, 2024
@cFireworks
Copy link
Contributor Author

cFireworks commented Aug 8, 2024 •
edited
Loading

The CI Env seems wrong during upload coverage report.

[2024-08-08T05:01:04.507Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.6-uploader-0.8.0&token=*******&branch=fix%2Fsupport_chinese_in_prompt_generation&build=10296180173&build_url=https%3A%2F%2Fgithub.com%2FSinaptik-AI%2Fpandas-ai%2Factions%2Fruns%2F10296180173&commit=cd3bf4294e13131a9d94fdcc1e6ae6bd9ae7b02d&job=ci&pr=1317&service=github-actions&slug=Sinaptik-AI%2Fpandas-ai&name=&tag=&flags=&parent=
[2024-08-08T05:01:04.676Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 2373s.', code='throttled')}

@cFireworks cFireworks closed this Aug 8, 2024
@cFireworks cFireworks reopened this Aug 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2024
@cFireworks
Copy link
Contributor Author

What should I do to continue the PR progressing?

@gventuri gventuri merged commit df06bec into Sinaptik-AI:main Oct 16, 2024
7 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArslanSaleem ArslanSaleem ArslanSaleem approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Chinese characters in prompt generation stage
3 participants
@cFireworks @ArslanSaleem @gventuri