Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some BBC and Markdown bugs #8362

Merged

Conversation

Sesquipedalian
Copy link
Member

@Sesquipedalian Sesquipedalian commented Dec 17, 2024

  • Fixes Some Markdown bugs #8360
    • Fixes issue where nested Markdown lists were parsed incorrectly
    • Go back to parsing smileys while parsing BBCode (fixes issue where smileys appeared inside code blocks)
    • Don't interrupt fenced code blocks when code is indented more than four spaces
    • Parses Markdown images correctly
  • Smarter list item markers for nested Markdown lists
  • Shows line breaks correctly in output from Parser::highlightPhpCode()
  • Fixes a bug when a [code] BBC contained the literal string [code]
  • Correctly parses Markdown emphasis wrapped around inline code, etc.
  • Fixes some issues displaying tab characters
  • Prevents overflow in code blocks in WYSIWYG editor mode

@live627
Copy link
Contributor

live627 commented Dec 18, 2024

Only remaining problem is images. Still see raw Markdown. Do I need to enable some setting? This fixes all other reported issues.

@Sesquipedalian
Copy link
Member Author

Oops. I overlooked the images issues. Thanks for bringing it to my attention.

@Sesquipedalian
Copy link
Member Author

Should now be fixed, @live627. Please confirm as soon as you are able. 🙂

Signed-off-by: Jon Stovell <[email protected]>
@live627
Copy link
Contributor

live627 commented Dec 19, 2024

That fixed it. I'm mow looking at malformed BBCode from https://github.com/live627/smf-custom-forms/blob/master/src/install.txt

Screenshot 2024-12-19 at 00-32-54 Preview of Re lorem ipsum egestas integer

@Sesquipedalian
Copy link
Member Author

That fixed it.

Excellent.

I'm mow looking at malformed BBCode from https://github.com/live627/smf-custom-forms/blob/master/src/install.txt

Screenshot 2024-12-19 at 00-32-54 Preview of Re lorem ipsum egestas integer

Let's deal with that as a distinct issue.

@Sesquipedalian Sesquipedalian merged commit cd2d0b9 into SimpleMachines:release-3.0 Dec 20, 2024
6 checks passed
@Sesquipedalian Sesquipedalian deleted the 3.0/markdown_fixes branch December 20, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Markdown bugs
2 participants