Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lets our entity handling methods work with all named HTML entities #8346

Merged

Conversation

Sesquipedalian
Copy link
Member

No description provided.

@Sesquipedalian Sesquipedalian merged commit 9dec9fc into SimpleMachines:release-3.0 Nov 26, 2024
6 checks passed
@Sesquipedalian Sesquipedalian deleted the 3.0/ent_list branch November 26, 2024 23:08
@jdarwood007
Copy link
Member

Is there a source this comes from to know when it needs updates? I don't think most humans could keep up with that.

@Sesquipedalian
Copy link
Member Author

Sesquipedalian commented Nov 27, 2024

It won't need updates. The values came from get_html_translation_table(HTML_ENTITIES, ENT_QUOTES | ENT_HTML5), and the list of named entities for HTML5 is a fixed value that won't be updated or expanded in the future (see note at bottom of page). If it weren't for that guarantee, I would have built the regex at runtime. But since the list is immutable, we can just hard-code the regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants