-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements recurring calendar events #8177
Merged
Sesquipedalian
merged 24 commits into
SimpleMachines:release-3.0
from
Sesquipedalian:recurring_events
May 1, 2024
Merged
Implements recurring calendar events #8177
Sesquipedalian
merged 24 commits into
SimpleMachines:release-3.0
from
Sesquipedalian:recurring_events
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sesquipedalian
force-pushed
the
recurring_events
branch
5 times, most recently
from
April 26, 2024 01:28
45d3c69
to
43a858a
Compare
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
It's a relic from before the calendar supported times, it doesn't work reliably for events with times, and even for all-day events its behaviour can be somewhat odd. Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
UI doesn't yet support adding multiple events to a topic, but that can come later. Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Sesquipedalian
force-pushed
the
recurring_events
branch
from
April 26, 2024 05:34
43a858a
to
4f37aa9
Compare
Sesquipedalian
requested review from
BrickOzp,
jdarwood007,
live627 and
tyrsson
April 26, 2024 19:51
1. Fixes problems where we weren't conforming to the spec. 2. Adds support for exporting recurring events. Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Sesquipedalian
force-pushed
the
recurring_events
branch
from
April 28, 2024 07:59
4f37aa9
to
1c0c52e
Compare
Signed-off-by: Jon Stovell <[email protected]> # Conflicts: # Sources/Actions/Admin/Calendar.php
Sesquipedalian
force-pushed
the
recurring_events
branch
3 times, most recently
from
April 30, 2024 05:30
8dd1fe7
to
d5556b2
Compare
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Signed-off-by: Jon Stovell <[email protected]>
Sesquipedalian
force-pushed
the
recurring_events
branch
from
April 30, 2024 06:50
d5556b2
to
fc92e92
Compare
Signed-off-by: Jon Stovell <[email protected]> # Conflicts: # other/upgrade_3-0_MySQL.sql # other/upgrade_3-0_PostgreSQL.sql
To heck with it. I've tested this PR a ton, and I am getting tired of resolving conflicts... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7935
This is a major upgrade to SMF's calendar system:
Implements support for recurring events in accordance with RFC 5545 (the iCalendar specification).
Events, holidays, and birthdays are now all classes, with SMF\Calendar\Holiday and SMF\Calendar\Birthday being extensions of SMF\Calendar\Event.
Adds support for importing iCalendar data from exteral sources.
Improves support for exporting iCalendar data.
Includes support for "special recurrence rules" that call custom PHP functions to calculate recurrence rules that are too complicated even for RFC 5545 to model.
Other changes include:
UI for creating recurring events
Recurrence info is included when displaying events in a topic or in list view
Improved export options
Admin panel for importing (and optionally subscribing to) external iCalendar data