Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not make up decimal places #8156

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

live627
Copy link
Contributor

@live627 live627 commented Mar 29, 2024

Lots of noise is generated when using the stem unlimited-precision

@live627 live627 added this to the 3.0 Alpha 2 milestone Mar 29, 2024
@live627 live627 linked an issue Mar 29, 2024 that may be closed by this pull request
@live627 live627 added the Localization Language & internationalization label Mar 29, 2024
@live627 live627 force-pushed the fmt branch 2 times, most recently from deb8b46 to 36bb563 Compare March 30, 2024 16:25
@Sesquipedalian
Copy link
Member

Might as well change the code on this line, too.

$precision = max(0, strlen(rtrim(sprintf('%.53F', abs($number + 0)), '0')) - strlen(strval(intval($number + 0))) - 1);

Lots of noise is generated when using the stem `unlimited-precision`

Signed-off-by: John Rayes <[email protected]>
@live627
Copy link
Contributor Author

live627 commented Mar 31, 2024

added, unsure if it's right or how to test if there is no off by one error.

@Sesquipedalian Sesquipedalian merged commit 1e8f91b into SimpleMachines:release-3.0 Apr 1, 2024
6 checks passed
@live627 live627 deleted the fmt branch April 6, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Language & internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$significant_decimals generates noise
2 participants