Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates membersAllowedTo() to fetch members within moderator groups #8150

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

live627
Copy link
Contributor

@live627 live627 commented Mar 27, 2024

No description provided.

@Sesquipedalian
Copy link
Member

Could you give a little more explanation of what this is meant to solve? The PR title makes sense in and of itself, but without explanatory context it is difficult to understand why the change is being made.

@live627 live627 changed the title Updates groupsAllowedTo() to fetch members within moderator groups Updates membersAllowedTo() to fetch members within moderator groups Apr 5, 2024
@live627
Copy link
Contributor Author

live627 commented Apr 5, 2024

User::membersAllowedTo() has a glaring defect in that it wouldn't fetch moderator groups. Also unravels the sql query to be simpler and easier to understand with a few unions to retain intended behavior.

One slight change to the public facing call; passing 0 as the board id will fetch moderators from all boards.

@Sesquipedalian
Copy link
Member

Thanks for the explanation. 🙂

@Sesquipedalian Sesquipedalian merged commit 40ee34a into SimpleMachines:release-3.0 Apr 6, 2024
6 checks passed
@live627 live627 deleted the mem branch November 29, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants