Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc notification fixes #7881

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Misc notification fixes #7881

merged 3 commits into from
Nov 13, 2023

Conversation

Sesquipedalian
Copy link
Member

Fixes a few bugs related to alerts and notifications:

  • fd0632f removes an obsolete require_once call that would cause a fatal error when viewing alerts.
  • 107cea9 fixes a bug where $props['visible'] would not be set correctly in SMF\Alert::createBatch().
  • 09e2ac1 fixes two bugs that would prevent notifications about new events from being sent.

@Sesquipedalian Sesquipedalian added this to the 3.0 Alpha 1 milestone Nov 13, 2023
@Sesquipedalian Sesquipedalian merged commit 99b5e15 into SimpleMachines:release-3.0 Nov 13, 2023
3 checks passed
@Sesquipedalian Sesquipedalian deleted the misc_notification_fixes branch November 14, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Notifications
Projects
None yet
Milestone
3.0 Alpha 1
Development

Successfully merging this pull request may close these issues.
1 participant
@Sesquipedalian