[3.0] Update our password conversion #7869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdarwood007
force-pushed
the
passwordConversion
branch
from
9cdd01a to
0486eb6
Compare
jdarwood007
changed the title
jdarwood007
force-pushed
the
passwordConversion
branch
5 times, most recently
from
ccb4b19 to
c57df03
Compare
jdarwood007
force-pushed
the
passwordConversion
branch
from
c57df03 to
6fe6c2c
Compare
|
Delightfully cleaner and clearer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7860
I reorganized the passwords to only check if the strlen matches first using a switch statement. No sense in trying to check passwords that won't produce a hash of the correct length.
I moved SMF's passwords from 1.1 to 2.0 outside of the checks better, since they are still supported as part of a native upgrade without conversion. SMF 1.0/YabbSE requires password conversions.
I thought about looking around at what password mechanisms are being used by forums nowadays, but I hope they have all switched over to the native password_* functions.