Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1] Add JS color picker for color input type fields #7715

Closed

Conversation

dragomano
Copy link
Contributor

@dragomano dragomano commented Mar 22, 2023

sshot-4

@DiegoAndresCortes
Copy link
Member

I like https://github.com/mdbassit/Coloris a bit more

@dragomano
Copy link
Contributor Author

Any such script is better than nothing.

@albertlast
Copy link
Collaborator

the script use gpl, could be a licence issue?
also no mobile/touchscreen version,
which would be less optimal than the default color picker of the browser?

@dragomano
Copy link
Contributor Author

Answer with screenshots from the official site :)

2023-03-24 03_53_25-Download   License - jscolor_ JavaScript Color picker - Vivaldi

2023-03-24 03_55_47-jscolor_ JavaScript Color picker with Opacity (alpha channel) - Vivaldi

You can test it on the sandbox page.

@jdarwood007
Copy link
Member

For 2.1 I do not see us adding this. Maybe in a future release

@albertlast
Copy link
Collaborator

Answer with screenshots from the official site :)

2023-03-24 03_53_25-Download License - jscolor_ JavaScript Color picker - Vivaldi

2023-03-24 03_55_47-jscolor_ JavaScript Color picker with Opacity (alpha channel) - Vivaldi

You can test it on the sandbox page.

yea so possible license issue and "mobile view" doesn't exists.

not the best sollution in my pov

@Sesquipedalian
Copy link
Member

SMF is released under a BSD-3 licence, which means SMF can't include code released under the GPL. GPL code can include BSD-3 code, but not the other way around.

@DiegoAndresCortes
Copy link
Member

"mobile view" doesn't exists.

It works fine on mobile, not sure what you mean, behaves like any other input.

@dragomano
Copy link
Contributor Author

Ok, I can change this to https://github.com/mdbassit/Coloris. It uses the MIT license.

@jdarwood007 jdarwood007 modified the milestones: The future, 3.0 Alpha 4 Jan 22, 2024
@dragomano dragomano changed the title Add JS color picker for color input type fields [2.1] Add JS color picker for color input type fields Mar 23, 2024
Signed-off-by: Bugo <[email protected]>
@live627
Copy link
Contributor

live627 commented Oct 7, 2024

@live627 live627 closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants