Trait Modify Factions #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
DEATHB4DEFEAT
requested changes
Sep 22, 2024
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>
FoxxoTrystan
added
Size: 4-Small
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: VMSolidus <[email protected]>
FoxxoTrystan
requested review from
a team,
DEATHB4DEFEAT,
Peptide90,
Pspritechologist and
OldDanceJacket
and removed request for
a team
github-actions
bot
added
Status: Needs Review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
DEATHB4DEFEAT
approved these changes
Oct 19, 2024
Remuchi
approved these changes
Oct 27, 2024
Remuchi
added
the
Status: Awaiting Merge
Peptide90
approved these changes
Oct 27, 2024
Signed-off-by: VMSolidus <[email protected]>
Ichaie
pushed a commit
to Ichaie/Einstein-Engines
that referenced
this pull request
Oct 27, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made by request from Nuclear14, while also adding a trait that was present both in Parkstation, as well as something N14 would like to have. This PR extends the TraitSystem so that it can now also add or remove Factions from a character. It also adds in the Animal Friend trait from Parkstation/Fallout: New Vegas.
Changelog
🆑