Ports Atmospheric Alerts Computer #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> - Ports the Atmospheric Alerts Computer, as implemented on WizDen --- # TODO <!-- A list of everything you have to do before this PR is "complete" You probably won't have to complete everything before merging but it's good to leave future references --> n/a --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p>  </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: zelezniciar - add: Added Atmospheric Alerts Computer
github-actions
bot
added
Changes: C#
|
mfw
|
|
This could be so much smaller with a bit of pattern matching. |
FoxxoTrystan
requested review from
VMSolidus,
FoxxoTrystan and
DEATHB4DEFEAT
FoxxoTrystan
added
Size: 3-Medium
|
Fuck it we should just leave this PR merged as-is, because I'm not about to open the can of worms that is "MERGE CONFLICT HELL" caused by cleaning up wizcode in the same PR that cherry-picks it. |
VMSolidus
approved these changes
Sep 17, 2024
|
Ehh il make my own review later. But by god |
|
I won't deny that it's shitcode, I can try and clean it up a bit, but... |
OldDanceJacket
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO
[x] small fixes
n/a
Media
Changelog
🆑 zelezniciar