-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Ghost Bar #904
base: master
Are you sure you want to change the base?
Port Ghost Bar #904
Conversation
* Ghost bar!!!! * Update Content.Server/Goobstation/Ghostbar/Components/GhostBarSpawnComponent.cs Co-authored-by: Rank #1 Jonestown partygoer <[email protected]> * Update Content.Server/Goobstation/Ghostbar/GhostBarSystem.cs Co-authored-by: Rank #1 Jonestown partygoer <[email protected]> * Update Content.Server/Goobstation/Ghostbar/GhostBarSystem.cs Co-authored-by: Rank #1 Jonestown partygoer <[email protected]> * Rule Window * Delete on ghost + Random job selection * Fix map --------- Co-authored-by: Rank #1 Jonestown partygoer <[email protected]>
Put the original PR's media in your description. |
done |
new JobComponent { Prototype = "Passenger" }, | ||
new JobComponent { Prototype = "Bartender" }, | ||
new JobComponent { Prototype = "Botanist" }, | ||
new JobComponent { Prototype = "Chef" }, | ||
new JobComponent { Prototype = "Janitor" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be validated.
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>
Thunderdome next for the station to watch ghosts fight it out? :) |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do that one unresolved thing
Bad idea, putting ghost players in the same map as the station will always lead to them finding ways to break out. I do plan on adding onto ghost bar in the future, giving it a secondary section with a gladiator arena that the ghost bar people can watch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the person who made this, ghost bar has some issues that need to be fixed before it should be merged. For some reason, this carries over the identity of the player completely, so if someone has a kill objective on the player, and they respawn at ghost bar, it will mark as failed. It's probably an easy fix, but i haven't bothered to look into it.
Checking out how objectives identify a target as dead should reveal how to fix it.
I may modify this myself to fix it. |
THUNDERDOME! :) It's red vs blue if you don't know where the players select their loadouts and battle it out with hammers and swords and stuff. Then link back to the station for people to watch. |
I actually already designed most of it, with a gladiator role/loadout + handheld TVs and body cams |
ragh!! the arcade machines should be rotated unless the media is just outdated |
when? |
+1 |
This was fixed on goob btw |
Wouldn't it be better to make it look like a ghost role rather than a button? Like in Blue Moon server in SS13 |
Antagonist targets appear on people in the ghost bar. |
Description
This PR ports Goob-Station/Goob-Station#454
By popular request from our Downstreams
Media
ghostbar.mp4
Changelog
🆑