Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Ghost Bar #904

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Sep 11, 2024

Description

This PR ports Goob-Station/Goob-Station#454
By popular request from our Downstreams

About the PR

Adds ghost bar :) Resolves #453

TODO:

* [x]  Spawn ghost map bar on round start

* [x]  Add button to ghost UI to spawn at ghost bar

* [x]  Warning popup before spawning

* [x]  Only allow players to spawn once to prevent them from creating piles of bodies (or delete their old body first?)

* [x]  Cleanup map.

Media

2024-08-02.01-38-29.mp4

* [x]  I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase

Changelog 🆑

* add: Ghost bar!

Media

ghostbar.mp4

Changelog

🆑

  • add: Ghost Bar has been ported from Goob Station

Aidenkrz and others added 2 commits September 10, 2024 22:16
* Ghost bar!!!!

* Update Content.Server/Goobstation/Ghostbar/Components/GhostBarSpawnComponent.cs

Co-authored-by: Rank #1 Jonestown partygoer <[email protected]>

* Update Content.Server/Goobstation/Ghostbar/GhostBarSystem.cs

Co-authored-by: Rank #1 Jonestown partygoer <[email protected]>

* Update Content.Server/Goobstation/Ghostbar/GhostBarSystem.cs

Co-authored-by: Rank #1 Jonestown partygoer <[email protected]>

* Rule Window

* Delete on ghost + Random job selection

* Fix map

---------

Co-authored-by: Rank #1 Jonestown partygoer <[email protected]>
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Map Changes any yml file in the Maps directories Changes: UI Changes any XAML files labels Sep 11, 2024
@DEATHB4DEFEAT
Copy link
Member

Put the original PR's media in your description.

@VMSolidus
Copy link
Member Author

Put the original PR's media in your description.

done

Comment on lines +28 to +32
new JobComponent { Prototype = "Passenger" },
new JobComponent { Prototype = "Bartender" },
new JobComponent { Prototype = "Botanist" },
new JobComponent { Prototype = "Chef" },
new JobComponent { Prototype = "Janitor" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be validated.

Content.Server/Ghostbar/GhostBarSystem.cs Outdated Show resolved Hide resolved
Content.Server/Ghostbar/GhostBarSystem.cs Outdated Show resolved Hide resolved
Content.Server/Ghostbar/GhostBarSystem.cs Outdated Show resolved Hide resolved
Content.Shared/Ghost/SharedGhostSystem.cs Outdated Show resolved Hide resolved
Resources/Locale/en-US/Goobstation/guidebook/ghost-gui.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/Goobstation/guidebook/ghost-gui.ftl Outdated Show resolved Hide resolved
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Signed-off-by: VMSolidus <[email protected]>
@Peptide90
Copy link
Contributor

Thunderdome next for the station to watch ghosts fight it out? :)

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 2, 2024
@FoxxoTrystan FoxxoTrystan added Size: 3-Medium For medium issues/PRs Priority: 3-Medium Needs to be resolved at some point labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Oct 4, 2024
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do that one unresolved thing

@Aidenkrz
Copy link
Contributor

Thunderdome next for the station to watch ghosts fight it out? :)

Bad idea, putting ghost players in the same map as the station will always lead to them finding ways to break out.

I do plan on adding onto ghost bar in the future, giving it a secondary section with a gladiator arena that the ghost bar people can watch.
The main bar everyone will spawn with pacifism, the gladiator arena people will spawn with random combat loadouts.

Copy link
Contributor

@Aidenkrz Aidenkrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the person who made this, ghost bar has some issues that need to be fixed before it should be merged. For some reason, this carries over the identity of the player completely, so if someone has a kill objective on the player, and they respawn at ghost bar, it will mark as failed. It's probably an easy fix, but i haven't bothered to look into it.

Checking out how objectives identify a target as dead should reveal how to fix it.

@Aidenkrz
Copy link
Contributor

I may modify this myself to fix it.

@Peptide90
Copy link
Contributor

Thunderdome next for the station to watch ghosts fight it out? :)

Bad idea, putting ghost players in the same map as the station will always lead to them finding ways to break out.

I do plan on adding onto ghost bar in the future, giving it a secondary section with a gladiator arena that the ghost bar people can watch. The main bar everyone will spawn with pacifism, the gladiator arena people will spawn with random combat loadouts.

THUNDERDOME! :) It's red vs blue if you don't know where the players select their loadouts and battle it out with hammers and swords and stuff. Then link back to the station for people to watch.

@Aidenkrz
Copy link
Contributor

Thunderdome next for the station to watch ghosts fight it out? :)

Bad idea, putting ghost players in the same map as the station will always lead to them finding ways to break out.
I do plan on adding onto ghost bar in the future, giving it a secondary section with a gladiator arena that the ghost bar people can watch. The main bar everyone will spawn with pacifism, the gladiator arena people will spawn with random combat loadouts.

THUNDERDOME! :) It's red vs blue if you don't know where the players select their loadouts and battle it out with hammers and swords and stuff. Then link back to the station for people to watch.

I actually already designed most of it, with a gladiator role/loadout + handheld TVs and body cams
Only issue that i hate is that i couldn't figure out how to get device networks to work across grids, Frontier peeps might know more about it

@bruhmogus
Copy link

ragh!! the arcade machines should be rotated unless the media is just outdated

@PuroSlavKing
Copy link
Contributor

when?

@v0idRift
Copy link
Contributor

+1

@Aidenkrz
Copy link
Contributor

Aidenkrz commented Dec 2, 2024

As the person who made this, ghost bar has some issues that need to be fixed before it should be merged. For some reason, this carries over the identity of the player completely, so if someone has a kill objective on the player, and they respawn at ghost bar, it will mark as failed. It's probably an easy fix, but i haven't bothered to look into it.

Checking out how objectives identify a target as dead should reveal how to fix it.

This was fixed on goob btw

@BL02DL
Copy link

BL02DL commented Dec 22, 2024

Wouldn't it be better to make it look like a ghost role rather than a button? Like in Blue Moon server in SS13

@Vonsant
Copy link

Vonsant commented Jan 1, 2025

Antagonist targets appear on people in the ghost bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Map Changes any yml file in the Maps directories Changes: UI Changes any XAML files Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Merge Conflict FIX YOUR PR AAAGH Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to cherry-pick PR #26434: Minor cleanup of cuffablesystem
10 participants