Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Added verb action to Glue/Lube system #303

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26002: Added verb action to Glue/Lube system from space-wizards space-wizards/space-station-14

70c718f61cd952f49f6908107edfbeeb3b7e41e0

PR opened by SlamBamActionman at 2024-03-11 15:15:49 UTC


PR changed 4 files with 67 additions and 25 deletions.

The PR had the following labels:


Original Body

About the PR

Added right-click Glue/Lube verbs (used by Space glue / lube tubes). This allows them to be used on containers and glasses.

Why / Balance

Attempting to glue/lube a container like a bag makes the insert verb take priority. Same for trying to glue/lube something like a glass, which empties the reagent into the container. That keeps those objects from being glued/lubed, but with a right-click verb it is now possible.

Technical details

Added a verb in each system using the Forensic Scanner verb implementation as a base. Had to move where the sound/pop-up message appears to avoid duplicating too much code.

Media

imageimage

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Space glue/lube tubes can now be used through the right-click menu.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
@VMSolidus VMSolidus marked this pull request as ready for review May 9, 2024 05:00
@VMSolidus VMSolidus merged commit 3c6c69a into Simple-Station:master May 9, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants