Mirror: Code Cleanup: Purge Obsolete MapManager Methods

[SimpleStation14]

Mirror of PR #26279: Code Cleanup: Purge obsolete MapManager methods from space-wizards/space-station-14

ae3d745430e3c5250d19553429e7cda2b8050d10

PR opened by Tayrtahn at 2024-03-20 02:51:49 UTC

---

PR changed 49 files with 97 additions and 122 deletions.

The PR had the following labels:

• Status: Needs Review

---

Original Body

About the PR

Cleans up some obsolete method calls.

Why / Balance

This is definitely low -hanging fruit on the code cleanup tree, but clearing out compiler warnings is always nice.

Technical details

Removes every use of obsolete MapManager methods (GetGrid, GridExists, and TryGetGrid), replacing them with appropriate EntityManager methods or their corresponding EntitySystem extension methods.

Media

Code

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

[DangerRevolution]

no idea what this does

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[VMSolidus]

I'm going to cherrypick my way through the failed mirrors and see if that fixes this first.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[DEATHB4DEFEAT]

2 files

[VMSolidus]

This was included in the engine PRs, and as such is no longer needed.