Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Thrown soap/banana/(etc?) will fail to slip until it lands #280

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #24494: Thrown soap/banana/(etc?) will fail to slip until it lands from space-wizards space-wizards/space-station-14

e061cb3f8c9dc8ddc26624ead2086dfb41465aae

PR opened by Errant-4 at 2024-01-25 00:04:36 UTC


PR changed 1 files with 21 additions and 1 deletions.

The PR had the following labels:

  • Status: Awaiting Changes

Original Body

About the PR

Thrown objects can no longer slip until they have landed. For a succesful slip, the attacker must now calculate how to throw the soap in front of/on the target. If the target is chasing and very close, it might be more effective to drop the soap/banana rather than throw it, but then this choice is another decision that must be quickly made to carry out the slip (also you can mess that up and slip yourself)

A "MISS" popup is displayed mostly just to communicate that this was not a glitch until players get used to the idea. This popup can be removed later if we don't want it

I tested what I could think of, but might have missed something, more eyes would be good on this one

fixes #18027

Why / Balance

Slips are too easy for how annoying (or potentially lethal) they are. Currently, slip throws are heavily slanted to succeed at short range, where they will nearly always hit. As the range increases, it becomes more and more possible to dodge. But it's basically impossible to fail the attack, the question is, will the target be able to anticipate and slow down to dodge it. This change is intended to make thrown slips, especially at short range, difficult for the attacker too, not just the target.

If the argument for the current state is that the target should git gud, why should that not also apply to the attacker?

(Also if we want to talk about what's "realistic", it also makes very little sense to yeet a banana peel at someone and have them fall over from that, unless one tacitly agrees that the attack automatically always hits right under their feet (yet keeps flying anyway) )

Media

soap.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

Make sure to take this Changelog template out of the comment block in order for it to show up.
🆑 Errant

  • tweak: Thrown objects can no longer slip while they are still in flight.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
@VMSolidus VMSolidus marked this pull request as ready for review May 12, 2024 03:16
@VMSolidus VMSolidus merged commit cd0be96 into Simple-Station:master May 12, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants