Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Bumps LoneOps minimum required players to 20 #263

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26244: Bumps LoneOps minimum required players to 20 from space-wizards space-wizards/space-station-14

61e31f4062b568591448ff5be83ba8be851269e9

PR opened by Boaz1111 at 2024-03-18 20:52:10 UTC


PR changed 1 files with 1 additions and 1 deletions.

The PR had the following labels:

  • No C#

Original Body

About the PR

I bumped LoneOps minimum required players to 20

Why / Balance

It was at 10, and loneops are extremely dangerous especially if there's no sec.

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 Boaz1111

  • tweak: Lone operatives now require a minimum of 20 players to spawn

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more players should be kept, rest reverted

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this is fine, 20 player minimums means a loneop with a china lake isn't going to solo an entire lowpop station.

@VMSolidus VMSolidus marked this pull request as ready for review May 12, 2024 04:09
@DangerRevolution DangerRevolution enabled auto-merge (squash) May 13, 2024 13:56
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be changed to the weight and start time of Delta

@DangerRevolution DangerRevolution added Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed Status: Awaiting Changes Do not merge due to requested changes Status: Needs Review Someone please review this labels May 13, 2024
@github-actions github-actions bot removed the Status: Awaiting Changes Do not merge due to requested changes label May 29, 2024
@DangerRevolution DangerRevolution merged commit 2961bf4 into Simple-Station:master Jun 20, 2024
11 checks passed
VMSolidus pushed a commit to VMSolidus/Einstein-Engines that referenced this pull request Jun 21, 2024
)

## Mirror of PR #26244: [Bumps LoneOps minimum required players to
20](space-wizards/space-station-14#26244) from
<img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `61e31f4062b568591448ff5be83ba8be851269e9`

PR opened by <img
src="https://avatars.githubusercontent.com/u/149967078?v=4"
width="16"/><a href="https://github.com/Boaz1111"> Boaz1111</a> at
2024-03-18 20:52:10 UTC

---

PR changed 1 files with 1 additions and 1 deletions.

The PR had the following labels:
- No C#


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> I bumped LoneOps minimum required players to 20
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> It was at 10, and loneops are extremely dangerous especially if
there's no sec.
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> 
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
> 🆑 Boaz1111
> - tweak: Lone operatives now require a minimum of 20 players to spawn


</details>

Co-authored-by: SimpleStation14 <Unknown>
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
…counted

X-Wave trait price has been lowered!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants