Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Small species melee weapon change #228

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26183: Small species melee weapon change from space-wizards space-wizards/space-station-14

0a8def1ea2dc4b7aee297098b3b50a7367f3c4d1

PR opened by Dutch-VanDerLinde at 2024-03-16 17:39:26 UTC


PR changed 4 files with 7 additions and 6 deletions.

The PR had the following labels:

  • No C#
  • Status: Needs Review

Original Body

About the PR

  • kobolds have the claw arc instead of the punch arc and do 5 slash 4 piercing instead of 9 piercing
  • arachnids make the carp bite sound similar to tarantulas and space spiders
  • lizards now make the slashing sound on hit instead of pierce, since they claw not pierce

Why / Balance

kobolds did the old lizard pierce animation when they clawed, made more sense

if space bears claw and make the slashing sound then lizards should too

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be carried over to Lamia/Harpie/Felinid/Oni

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't actually need to be carried over to other creatures.

@VMSolidus VMSolidus marked this pull request as ready for review May 12, 2024 03:21
@DangerRevolution DangerRevolution merged commit c99501f into Simple-Station:master May 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants