Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Added cheap sunglasses into ClothesMate #209

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25479: Added cheap sunglasses into ClothesMate from space-wizards space-wizards/space-station-14

d370f16e04fc12c8fa2b89c41c3fce12225334b4

PR opened by shampunj at 2024-02-22 21:58:13 UTC


PR changed 3 files with 15 additions and 7 deletions.

The PR had the following labels:

  • No C#
  • Status: Needs Review
  • Merge Conflict

Original Body

About the PR

Added cheap sunglasses that wasnt protect against flashing into ClothesMate

Why / Balance

To replace removed regular sunglasses in ClothesMate space-wizards/space-station-14#25221

Technical details

n/a

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
    Screenshot_53
    Screenshot_54

Breaking changes

Changelog

  • add: Added cheap sunglasses that wasnt protect against flashing into ClothesMate

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs price changes

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 5, 2024 19:55
@github-actions github-actions bot added the Changes: YML Changes any yml files label May 5, 2024
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Price changes are done, and this is next on the Pre-requisites list for DeltaV PRs

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There really should be different buy / sell prices. So you can buy something for 10K and sell for 0. As an example.

@VMSolidus
Copy link
Member

I mean you can, it's just that we can't actually set the sell price of crates directly because it's summed by all the contents of the crates. The system only cares that sell price must be equal to or less than buy price, but we can only set the buy price directly.

@VMSolidus VMSolidus merged commit 9b8441f into Simple-Station:master May 5, 2024
10 checks passed
@AeraAuling
Copy link

I mean you can, it's just that we can't actually set the sell price of crates directly because it's summed by all the contents of the crates. The system only cares that sell price must be equal to or less than buy price, but we can only set the buy price directly.

i'd suggest asking frontier about stuff like this, they have stuff like the cargo crates that don't adhere to this system by selling for more then you buy them for. dunno how they do it, but they might have worked out a way to set sell prices as well

@DEATHB4DEFEAT
Copy link
Member

they have stuff like the cargo crates that don't adhere to this system by selling for more then you buy them for

That's not good.

@VMSolidus
Copy link
Member

they have stuff like the cargo crates that don't adhere to this system by selling for more then you buy them for

That's not good.

For context the crates in question can only be sold at a profit at an entirely different station than the one you bought them at. You get money in exchange for transporting them to another station.

Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants