Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Fixed bug with appearance of ammo battery magazine guns #182

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26009: Fixed bug with appearance of ammo battery magazine guns from space-wizards space-wizards/space-station-14

63232389ca9a499fb614960ccf9eae9b3d186037

PR opened by 778b at 2024-03-11 18:34:37 UTC


PR changed 1 files with 9 additions and 0 deletions.

The PR had the following labels:


Original Body

About the PR

Fix bug with guns which used MagazineAmmoProviderComponent with Battery magazines like svalinn laser pistol.

Why / Balance

Bugfix, no balance here

Technical details

Just added subscribe for AmmoCounterControlEvent which using AmmoCounterComponent because battery magazines must redefine control in this event to display ammo, now its work well.
Also checked some other guns which using MagazineAmmoProviderComponent and they work like always, without new bugs

Media

Before:
Content Client_XpYbOTUw9U

After:
https://github.com/space-wizards/space-station-14/assets/33431126/d4aa3c99-7e89-44d7-9030-1fa2a3db13ab

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 778b

  • fix: Guns which use battery as magazines now display ammo. Like Svalinn pistol.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 6, 2024 18:43
@VMSolidus VMSolidus merged commit 14f012b into Simple-Station:master May 6, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 14, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants