Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Enable multiple Solution Editor windows #157

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26005: Enable multiple Solution Editor windows from space-wizards space-wizards/space-station-14

0da09db99ac556e0efdce40268e60eb5a06a0694

PR opened by SlamBamActionman at 2024-03-11 17:16:10 UTC
PR merged by web-flow at 2024-03-12 12:10:10 UTC


PR changed 2 files with 26 additions and 11 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

About the PR

Makes it so that you can have multiple debug Solution Editor/Add Reagent windows open at once.

Why / Balance

Admin request. Useful if you want to multitask editing multiple solution containers and their contents.

Technical details

Previously the open Solution Editor window was being tracked by a Dictionary which mapped the window entity to a session ID. That Dictionary instead uses a list of window entities mapped to the session ID, allowing for multiple windows.

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

no cl no fun

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 6, 2024 18:46
@VMSolidus VMSolidus merged commit 40d05b8 into Simple-Station:master May 6, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
sleepyyapril added a commit to sleepyyapril/Einstein-Engines that referenced this pull request Jan 21, 2025
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Do you want to add some extra pronouns to your character? Well here you
go! Primary pronouns are used by the game, but with this you can have a
little thing in your examine window that tells people your secondary
pronouns!

![image](https://github.com/user-attachments/assets/7bb33945-8ed3-42de-84fd-d81ce2b58a87)


---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- add: Added cosmetic pronouns as a way to better tell people what you
go by.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants