Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Shadow Shackles Not Activating for Blood Cultists #1456

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

Lumminal
Copy link
Contributor

@Lumminal Lumminal commented Jan 7, 2025

Description

Fixed Shadow Shackles not activating when you melee hit the target.

The Problem: The code checked if the target wasn't stunned when you hit someone, therefore not activating unless the target was already stunned. I fixed it by removing the ! operator on HasComp<StunnedComponent>(target) check.


Media

fix.mp4


Changelog

🆑

  • fix: Fixed Shadow Shackles spell not activating.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jan 7, 2025
@Remuchi
Copy link
Contributor

Remuchi commented Jan 7, 2025

strangely how I didn't receive reports about it when playing on WWDP and though it was already fixed

@sleepyyapril sleepyyapril merged commit 70f7298 into Simple-Station:master Jan 8, 2025
10 of 11 checks passed
SimpleStation14 added a commit that referenced this pull request Jan 8, 2025
@Lumminal Lumminal deleted the shadow-shackles-fix branch January 10, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants