Some MobState Refactoring #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
sleepyyapril
approved these changes
Jan 2, 2025
DEATHB4DEFEAT
approved these changes
Jan 2, 2025
Comment on lines
+438
to
+472
| if (AllowMovementWhileCrit is not null) | ||
| mobStateComponent.AllowMovementWhileCrit = AllowMovementWhileCrit.Value; | ||
|
|
||
| if (AllowMovementWhileSoftCrit is not null) | ||
| mobStateComponent.AllowHandInteractWhileSoftCrit = AllowMovementWhileSoftCrit.Value; | ||
|
|
||
| if (AllowMovementWhileDead is not null) | ||
| mobStateComponent.AllowMovementWhileDead = AllowMovementWhileDead.Value; | ||
|
|
||
| if (AllowTalkingWhileCrit is not null) | ||
| mobStateComponent.AllowTalkingWhileCrit = AllowTalkingWhileCrit.Value; | ||
|
|
||
| if (AllowTalkingWhileSoftCrit is not null) | ||
| mobStateComponent.AllowTalkingWhileSoftCrit = AllowTalkingWhileSoftCrit.Value; | ||
|
|
||
| if (AllowTalkingWhileDead is not null) | ||
| mobStateComponent.AllowTalkingWhileDead = AllowTalkingWhileDead.Value; | ||
|
|
||
| if (DownWhenCrit is not null) | ||
| mobStateComponent.DownWhenCrit = DownWhenCrit.Value; | ||
|
|
||
| if (DownWhenSoftCrit is not null) | ||
| mobStateComponent.DownWhenSoftCrit = DownWhenSoftCrit.Value; | ||
|
|
||
| if (DownWhenDead is not null) | ||
| mobStateComponent.DownWhenDead = DownWhenDead.Value; | ||
|
|
||
| if (AllowHandInteractWhileCrit is not null) | ||
| mobStateComponent.AllowHandInteractWhileCrit = AllowHandInteractWhileCrit.Value; | ||
|
|
||
| if (AllowHandInteractWhileSoftCrit is not null) | ||
| mobStateComponent.AllowHandInteractWhileSoftCrit = AllowHandInteractWhileSoftCrit.Value; | ||
|
|
||
| if (AllowHandInteractWhileDead is not null) | ||
| mobStateComponent.AllowHandInteractWhileDead = AllowHandInteractWhileDead.Value; |
There was a problem hiding this comment.
hate this, is there no better way?
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: VMSolidus <[email protected]>
SimpleStation14
added a commit
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does some refactoring of MobState in preparation for adding a more in-depth SoftCritical system, mostly adding code support for the new threshold existing in the first place. Additionally, the MobStateComponent now also includes several DataFields that allow more precise fine tuning of what all mobs are allowed to do in each state, as opposed to hardcoding a majority of these interactions.
The actual SoftCritical state isn't currently used by anything, and so is a largely vestigial feature. It would have to be added individually to mobs, such as the BaseMobSpeciesOrganic when the time comes to actually add this feature.
Changelog
🆑