Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Atmopsheric Network Monitoring #1312

Closed

Conversation

zelezniciar1
Copy link
Contributor

@zelezniciar1 zelezniciar1 commented Dec 4, 2024

Description

This PR introduces the Atmospheric Network Console and gas pipe sensors, allowing Atmospheric Technicians to remotely monitor the state of pipenets. This has applications in monitoring distro pressure, supermatter cooling loop status, and locating atmospheric sabotage in the form of passive vents attached to distro.

This will require mapping these consoles on all stations, and critically, will require all distro, waste, and supermatter pipenets to have a gas pipe sensor added and linked to the console.

This is a port of Wizden #33128 and Wizden #33294 by @chromiumboy

tl;dr we are one step closer to fully-remote automated turing-complete atmos


TODO

  • Atmos Network Console
  • Gas Pipe Sensor

Media

Snímka obrazovky 2024-12-04 115117
Snímka obrazovky 2024-12-04 115203


Changelog

🆑 zelezniciar

  • add: Atmospheric Network Monitoring Console is now avaliable
  • add: Gas Pipe Sensors are now avaliable

chromiumboy and others added 2 commits December 4, 2024 09:50
* Initial commit

* Monitored pipe node is now referenced by name

* Review changes

* Simplified construction

* Tweaked deconstruction to match other binary atmos devices

* Helper function removal

* Updated attribution

(cherry picked from commit 403528cbf344531fedd3b5038f6463ba12eea41a)
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an RSI labels Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

RSI Diff Bot; head commit 3679421 merging into c223259
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Piping/Atmospherics/gas_pipe_sensor.rsi

State Old New Status
base Added
blank Added
icon Added
lights Added

Edit: diff updated after 3679421

@zelezniciar1
Copy link
Contributor Author

Draft PR as Network Console is still being worked on :)

chromiumboy and others added 3 commits December 4, 2024 15:16
(cherry picked from commit 1ed459840c2167968042563ff6b6458e37d568c4)
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jan 20, 2025
@stellar-novas
Copy link
Contributor

Does #1610 achieve everything this pr adds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files Status: Merge Conflict FIX YOUR PR AAAGH
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants