Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Localization for Senior Physician and Senior Engineer #1302

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

zelezniciar1
Copy link
Contributor

Description

Adds localization for the Senior Engineer and Senior Physician roles that were recently enabled.


TODO

n/a


Media

Snímka obrazovky 2024-12-01 164702
Snímka obrazovky 2024-12-01 165626


Changelog

🆑 zelezniciar

  • fix: Fixed Senior Engineer and Physician names not appearing correctly

@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Dec 1, 2024
@SimpleStation14 SimpleStation14 changed the title Add localization for Senior Physician and Senior Engineer Add Localization for Senior Physician and Senior Engineer Dec 1, 2024
@sleepyyapril
Copy link
Contributor

@VMSolidus If this was not intended, this is a thing by the way. You can join as Senior roles now.

@zelezniciar1
Copy link
Contributor Author

Also, I'm pretty sure the testfail is unrelated?

@sleepyyapril
Copy link
Contributor

Also, I'm pretty sure the testfail is unrelated?

It is!

@VMSolidus
Copy link
Member

@VMSolidus If this was not intended, this is a thing by the way. You can join as Senior roles now.

No it's intended, they're actually supported by loadouts now. Although not every map has them yet.

@sleepyyapril
Copy link
Contributor

Okay, approve so we fix the silly locale issue lmao.

Also, what would it take to add alternate titles?

@sleepyyapril sleepyyapril added Priority: 2-High Needs to be resolved as soon as possible Size: 5-Very Small For especially small issues/PRs Type: Bug [Un]intentional issue with something labels Dec 1, 2024
@VMSolidus VMSolidus merged commit 4bf7624 into Simple-Station:master Dec 1, 2024
11 of 12 checks passed
@zelezniciar1 zelezniciar1 deleted the fix-job-name branch December 2, 2024 01:30
sleepyyapril pushed a commit to angelofallars/Einstein-Engines that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Size: 5-Very Small For especially small issues/PRs Type: Bug [Un]intentional issue with something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants