Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loadouts Lore Documentation #1298

Merged
merged 3 commits into from
Dec 1, 2024

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Nov 30, 2024

Description

This PR adds several Xml documents, to be included as supplementary lore that can be linked to by Loadout entries, particularly ones that make reference to a specific corporation. This also includes a document for Security weapons, which clarifies their usage to players.

Additionally, this fixes an issue with Loadouts, whereby because of the use of string-matching, it wasn't possible for more than one loadout item to share a guidebook. Instead, Loadouts can now directly declare a specific guidebook to link to.

TODO

Add lore for the following:

  • Einstein Engines
  • Idris Incorporated
  • Stellar Corporate Conglomerate
  • NanoTrasen
  • Orion Express
  • Zeng-Hu Pharmaceuticals
  • Hephaestus Heavy Industries
  • Zavodskoi Interstellar
  • Private Military Contracting Group

Media

image

Changelog

🆑

  • add: Added a guidebook entry on Security Duty Weapons
  • add: Added guidebook entries on various Corporations in lore, such as Einstein Engines, Hephaestus Heavy Industries, etc.
  • add: Loadouts can now link to a specific guidebook entry via prototype ID.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: UI Changes any XAML files Changes: Documentation Changes any xml or md files Changes: YML Changes any yml files labels Nov 30, 2024
@github-actions github-actions bot added the Changes: Localization Changes any ftl files label Dec 1, 2024
@VMSolidus
Copy link
Member Author

I am finally done.
image

image

image

@VMSolidus
Copy link
Member Author

As usual, test fails are unrelated to this PR. Guh.

@sleepyyapril sleepyyapril merged commit a535d98 into Simple-Station:master Dec 1, 2024
10 of 11 checks passed
sleepyyapril pushed a commit to sleepyyapril/Einstein-Engines that referenced this pull request Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants