Shitmed Update 2 - [Insert Snarky Remark] #1271

gluesniffler · 2024-11-23T23:49:18Z

Description

Honey wake up, another shitmed PR with 5 features and a trillion bugs! I love bloat.

Known Bugs

A lot of shit with changelings lol
Markings suddenly disappear from your entity apparently at random. Wizden exclusive issue as of now.
Fire heretics explode when ascending due to part damage shitcode (sorry)
Some exceptions/null point references at round end, tentatively related to salvage corpses.
Slots having wonky behavior due to not being networked. More of a broad issue with how I implemented them initially.
Arachne are FUCKED with surgery, I was incredibly tempted to set them to roundstart: false, but I'll try to hotfix it this week.

Changelog

🆑 Mocho, Deltanedas

add: Ported Ghetto Surgery from Deltanedas!
add: Ported fishops organs from Deltanedas!
add: Added different step durations to each surgery step.
add: Added a T2 research for advanced surgical tools
add: Added a T3 research for an omnitool for surgery.
add: Added Surgical and Advanced Surgical modules for Mediborgs
add: Mediborgs can now perform surgery!
add: Added lobotomies as an operation. Godspeed you psychopaths.
add: Added cybernetic arms, legs and eyes.
add: Added EMP weaknesses to all cybernetic parts (the day of reckoning will come for IPCs soon)
add: Losing your eyes now blinds you.
fix: Fixed a few species that did not inherit from BasePart's, thus taking damage types they shouldn't on their limbs.
fix: Fixed harpy lungs not being usable in surgeries.
fix: Fixed biosynthetic and other printable parts not allowing you to attach body parts to them.
fix: Fixed fire being able to destroy your chest.
fix: Fixed entities being able to take over your body by just inserting a brain or another head on top of you.
fix: Fixed some shitcode that didnt let rejuvenate or godmode work properly.
fix: Fixed bionic arm, and cybernetic eyes traits not working properly due to shitty networking.
tweak: Increased tend wounds's speed by double, and bumped up the values on its calculations. DEATH TO TOPICALS, LEAVE THOSE TO TIDERS.
tweak: Beheading an entity now doesnt let it move, speak, and forces it to the ground immediately (literally 1984!!11!!)
tweak: Changed sprites on most surgical tools to now use /tg/ sprites.
tweak: Unbound shitmed targeting doll keybinds by default (did you know we have those).

…ngines into SHITMED

…amage

…art gibbing

…yzerUIWizden Updated Health Analyzer UI From Latest Wizden Update

* hide spriteview from health analyzer while inactive * add out of range indicator if analyzer becomes inactive * hide out of range icon if there is no patient data

* Add health analyzer unrevivability warning * Remove errornous comment

github-actions · 2024-11-23T23:49:58Z

RSI Diff Bot; head commit ca07b12 merging into dcc1c38
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Medical/Surgery/bonesetter.rsi

State	Old	New	Status
bonesetter			Modified
predator_bonesetter			Removed
inhand-left			Added
inhand-right			Added

Resources/Textures/Objects/Specific/Medical/Surgery/cautery.rsi

State	Old	New	Status
cautery			Modified
inhand-left			Modified
inhand-right			Modified

Resources/Textures/Objects/Specific/Medical/Surgery/drill.rsi

State	Old	New	Status
drill			Modified
inhand-left			Modified
inhand-right			Modified
0			Removed
100			Removed
25			Removed
50			Removed
75			Removed

Resources/Textures/Objects/Specific/Medical/Surgery/scalpel.rsi

State	Old	New	Status
inhand-left			Modified
inhand-right			Modified
scalpel			Modified

Resources/Textures/Objects/Specific/Medical/Surgery/bone_gel.rsi

State	Old	New	Status
bone-gel			Removed
bone-gel_0			Removed
bone-gel_25			Removed
bone-gel_50			Removed
bone-gel_75			Removed
predator_bone-gel			Removed

Resources/Textures/Objects/Specific/Medical/Surgery/scissors.rsi

State	Old	New	Status
hemostat-inhand-left			Removed
hemostat-inhand-right			Removed
hemostat			Removed
inhand-left			Removed
inhand-right			Removed
retractor			Removed
setter-inhand-left			Removed
setter-inhand-right			Removed
setter			Removed

Resources/Textures/Mobs/Aliens/Carps/carp_parts.rsi

State	Old	New	Status
tail			Added
torso			Added

Resources/Textures/Mobs/Customization/cyberlimbs/bishop/bishop_main.rsi

State	Old	New	Status
l_arm-combined			Added
l_leg-combined			Added
r_arm-combined			Added
r_leg-combined			Added

Resources/Textures/Mobs/Species/IPC/organs.rsi

State	Old	New	Status
eyes			Added

Resources/Textures/Objects/Specific/Medical/Surgery/adv-retractor.rsi

State	Old	New	Status
adv-retractor-on			Added
adv-retractor			Added
inhand-left-on			Added
inhand-left			Added
inhand-right-on			Added
inhand-right			Added

Resources/Textures/Objects/Specific/Medical/Surgery/bone-gel.rsi

State	Old	New	Status
bone-gel			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/Objects/Specific/Medical/Surgery/circular-saw.rsi

State	Old	New	Status
circular-saw			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/Objects/Specific/Medical/Surgery/drapes.rsi

State	Old	New	Status
drapes			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/Objects/Specific/Medical/Surgery/e-cautery.rsi

State	Old	New	Status
e-cautery-on			Added
e-cautery			Added
inhand-left-on			Added
inhand-left			Added
inhand-right-on			Added
inhand-right			Added

Resources/Textures/Objects/Specific/Medical/Surgery/e-scalpel.rsi

State	Old	New	Status
e-scalpel-on			Added
e-scalpel			Added
inhand-left-on			Added
inhand-left			Added
inhand-right-on			Added
inhand-right			Added

Resources/Textures/Objects/Specific/Medical/Surgery/hemostat.rsi

State	Old	New	Status
hemostat			Added
inhand-left			Added
inhand-right			Added

Resources/Textures/Objects/Specific/Medical/Surgery/oldscalpel.rsi

State	Old	New	Status
inhand-left			Added
inhand-right			Added
scalpel			Added

Resources/Textures/Objects/Specific/Medical/Surgery/omnimed.rsi

State	Old	New	Status
inhand-left			Added
inhand-right			Added
omnimed			Added

Resources/Textures/Objects/Specific/Medical/Surgery/retractor.rsi

State	Old	New	Status
inhand-left			Added
inhand-right			Added
retractor			Added

Resources/Textures/Objects/Specific/Robotics/borgmodule.rsi

State	Old	New	Status
icon-advanced-surgery			Added
icon-surgery			Added

Edit: diff updated after ca07b12

# Description  Includes: - Disposals fixes and engine update (Simple-Station/Einstein-Engines#1270) - Shitmed update (Simple-Station/Einstein-Engines#1271) --- # Changelog  :cl: Mocho, deltanedas * add: Ported Ghetto Surgery from Deltanedas! * add: Ported fishops organs from Deltanedas! * add: Added different step durations to each surgery step. * add: Added a T2 research for advanced surgical tools * add: Added a T3 research for an omnitool for surgery. * add: Added Surgical and Advanced Surgical modules for Mediborgs * add: Mediborgs can now perform surgery! * add: Added lobotomies as an operation. Godspeed you psychopaths. * add: Added cybernetic arms, legs and eyes. * add: Added EMP weaknesses to all cybernetic parts (the day of reckoning will come for IPCs soon) * add: Losing your eyes now blinds you. * fix: Fixed harpy lungs not being usable in surgeries. * fix: Fixed biosynthetic and other printable parts not allowing you to attach body parts to them. * fix: Fixed fire being able to delimb you. * fix: Fixed entities being able to take over your body by just inserting a brain or another head on top of you. * fix: Fixed some shitcode that didnt let rejuvenate or godmode work properly. * fix: Fixed bionic arm, and cybernetic eyes traits not working properly due to shitty networking. * tweak: Increased tend wounds's speed by double, and bumped up the values on its calculations. DEATH TO TOPICALS, LEAVE THOSE TO TIDERS. * tweak: Beheading an entity now doesnt let it move, speak, and forces it to the ground immediately (literally 1984!!11!!) * tweak: Changed sprites on most surgical tools to now use /tg/ sprites. * tweak: Unbound shitmed targeting doll keybinds by default (did you know we have those).

gluesniffler · 2024-11-24T01:42:52Z

Think thats a heisentest? Previous commit had passed all tests.

Tmanzxd · 2024-11-24T09:51:27Z

Test fail real: Can't resolve "Content.Shared.Body.Components.BodyComponent" on entity (13796/n13796)!

sleepyyapril · 2024-11-24T14:00:27Z

Test fail real: Can't resolve "Content.Shared.Body.Components.BodyComponent" on entity (13796/n13796)!

Did you not check the new tests, silly?

sleepyyapril · 2024-11-24T14:00:35Z

No test fails

Erisfiregamer1

As the C# Person for Arcadis I can say with a confidence of 0.01% that this fixes more bugs than it introduces.

sleepyyapril · 2024-11-24T15:22:34Z

As the C# Person for Arcadis I can say with a confidence of 0.01% that this fixes more bugs than it introduces.

sick, merge it immediately!!

Erisfiregamer1 · 2024-11-24T15:23:14Z

As the C# Person for Arcadis I can say with a confidence of 0.01% that this fixes more bugs than it introduces.

sick, merge it immediately!!

i stand by this statement (we moved fast and broke stuff, now we need to fix what broke)

sleepyyapril · 2024-11-24T15:23:46Z

As the C# Person for Arcadis I can say with a confidence of 0.01% that this fixes more bugs than it introduces.

sick, merge it immediately!!

i stand by this statement (we moved fast and broke stuff, now we need to fix what broke)

no, i want more bugs. in fact, revert all fixes!

VMSolidus

Even more fun. Well let's get these bugs fixed.

Tmanzxd · 2024-11-25T02:06:33Z

Test fail real: Can't resolve "Content.Shared.Body.Components.BodyComponent" on entity (13796/n13796)!

Did you not check the new tests, silly?

was the fails from 4 hours before that comment irrelevant now lol

rbertoche · 2024-11-27T09:24:14Z

Nice.
Just that :P

gluesniffler and others added 30 commits October 5, 2024 10:35

this might be the biggest piece of shitmed drama

9ba5958

Added layout for the proper bodydoll

cd6c0ce

Merge branch 'master' of https://github.com/Simple-Station/Einstein-E…

0f6c2ab

…ngines into SHITMED

Added body doll, and currently broken status doll.

989d831

forgor to add this shit

06e2a1c

Added body status doll, added real squares to doll, tweaked part removal

c4ff6b5

Update 2, body doll, severing drops, healing and command binds

87e45f3

Changed canTarget for a multiplier that can go on calls to TryChangeD…

2e0b0bb

…amage

surgery real

da41313

Small checkpoint save

fa5a39d

Bunch o updates for the weekend.

8c24925

Added malpractice penalties, repeatable tend wounds surgeries, body p…

c9cb2b8

…art gibbing

insertion surgery, some fixes to wound tending

a1fec38

Busting bugs

d20684e

buggymed

6ccc751

Draft PR commit.

2e785a2

this is all shitcode

285c468

another attempt?

87a2520

saving before switching to master

57563a9

fixed part reattachment slots and cavity implant surgery

3ea0335

removed loggers trol

fd206e8

leaving some tests running

990fa8a

Fixed a buncho crap

716811d

Added some experimental lag fixes to surgery. Might have crashes

917ade3

defelinization almost real

3ca30f8

Merge pull request Simple-Station#169 from XavierSomething/HealthAnal…

1d38934

…yzerUIWizden Updated Health Analyzer UI From Latest Wizden Update

Fix medical PDA/health analyzer long range intel bug (#31879)

f3af74f

* hide spriteview from health analyzer while inactive * add out of range indicator if analyzer becomes inactive * hide out of range icon if there is no patient data

Add health analyzer unrevivability warning (#32636)

bd11689

* Add health analyzer unrevivability warning * Remove errornous comment

helth

4c17800

fixed some rich text issues

86eac6e

github-actions bot added Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: Map Changes any yml file in the Maps directories Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an RSI labels Nov 23, 2024

sleepyyapril mentioned this pull request Nov 24, 2024

Shitmed Update, Bug Fixes, and Engine Update TheDenSS14/TheDen#63

Merged

gluesniffler and others added 3 commits November 23, 2024 20:16

Forever my hero.

6e43a13

I am your biggest fan

b53eb64

Merge branch 'master' into SHITMED

b5e47e0

gluesniffler added 2 commits November 23, 2024 20:52

I fall down the horseback

8e1823b

With my crippled legs

ca07b12

gluesniffler mentioned this pull request Nov 24, 2024

Invuln from admin verb doesn't protect limbs #1275

Open

sleepyyapril approved these changes Nov 24, 2024

View reviewed changes

Erisfiregamer1 approved these changes Nov 24, 2024

View reviewed changes

VMSolidus approved these changes Nov 24, 2024

View reviewed changes

gluesniffler mentioned this pull request Nov 24, 2024

Shitmed Update 2 - bottom text Goob-Station/Goob-Station#956

Merged

3 tasks

OldDanceJacket approved these changes Nov 30, 2024

View reviewed changes

VMSolidus merged commit 2eafa0d into Simple-Station:master Nov 30, 2024
14 checks passed

sleepyyapril pushed a commit to sleepyyapril/Einstein-Engines that referenced this pull request Nov 30, 2024

Automatic Changelog Update (Simple-Station#1271)

d58d397

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shitmed Update 2 - [Insert Snarky Remark] #1271

Shitmed Update 2 - [Insert Snarky Remark] #1271

gluesniffler commented Nov 23, 2024 •

edited

Loading

github-actions bot commented Nov 23, 2024 •

edited

Loading

gluesniffler commented Nov 24, 2024

Tmanzxd commented Nov 24, 2024

sleepyyapril commented Nov 24, 2024

sleepyyapril commented Nov 24, 2024

Erisfiregamer1 left a comment •

edited

Loading

sleepyyapril commented Nov 24, 2024

Erisfiregamer1 commented Nov 24, 2024

sleepyyapril commented Nov 24, 2024

VMSolidus left a comment

Tmanzxd commented Nov 25, 2024

rbertoche commented Nov 27, 2024

Shitmed Update 2 - [Insert Snarky Remark] #1271

Shitmed Update 2 - [Insert Snarky Remark] #1271

Conversation

gluesniffler commented Nov 23, 2024 • edited Loading

Description

Known Bugs

Changelog

github-actions bot commented Nov 23, 2024 • edited Loading

gluesniffler commented Nov 24, 2024

Tmanzxd commented Nov 24, 2024

sleepyyapril commented Nov 24, 2024

sleepyyapril commented Nov 24, 2024

Erisfiregamer1 left a comment • edited Loading

Choose a reason for hiding this comment

sleepyyapril commented Nov 24, 2024

Erisfiregamer1 commented Nov 24, 2024

sleepyyapril commented Nov 24, 2024

VMSolidus left a comment

Choose a reason for hiding this comment

Tmanzxd commented Nov 25, 2024

rbertoche commented Nov 27, 2024

gluesniffler commented Nov 23, 2024 •

edited

Loading

github-actions bot commented Nov 23, 2024 •

edited

Loading

Erisfiregamer1 left a comment •

edited

Loading