Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buff Medical Due to Shitmed Changes Cherry-Pick #1259

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

Tmanzxd
Copy link
Contributor

@Tmanzxd Tmanzxd commented Nov 20, 2024

Description

  • Buffed applicable medication heal values.
  • Buffed applicable medication stack sizes.
  • Slightly buffed dylovene, burn, and brute chems.
  • Buffed applicable medication doAfter delay from 3s to 2s.

Why / Balance

This change was made with the advent of the new Limb Damage system. This PR seeks to achieve making SS14 Medical more equivalent to SS13 Medical when it comes to healing damage values.

This was done as Bruise Packs and Ointment only heal 5 Brute or 5 Burn respectively when applied to a limb. When each limb has a 100 Crit threshold, this can make it extremely hard even with surgery to heal limbs in the absence of Chemicals.

Furthermore on higher pop, this will lead to people burning through applicable meds even faster than before Limb Damage was implemented. It would take 34 bruise packs to heal someone with 170 Blunt spread out across their limbs, with this change it would reduce that to 12 bruise packs.

Full list of numerical val changes:

  • Healing component doAfter Delay reduced. was 3s, now its 2s.
  • Applicable medical items now have a max stack size of 15 (was 10).
  • Ointment heals 15 of each burn type, 10 caustic (was 5 of each burn type, 1.5 caustic)
  • Mesh now heals 20 of each burn type (was 10 of each burn type).
  • Bruise Packs now heal 15 of each brute type (was 5 of each brute type)
  • Sutures now heal 20 of each brute type (was 10 of each brute type)
  • Bloodpacks now heal 2.5 Bloodloss & restore 10% bloodlevel (was .5 Bloodloss and 5%)
  • Gauzes now heal 15 Slash and 20 Pierce (was 5 Slash and 10 Pierce)
  • Dylovene now heals 1.5 Poison per .5u (was 1 Poison per .5u)
  • Bicaridine now heals 2.5 Brute per .5u (Was 2 Brute per .5u)
  • Dermaline now heals 2 Burn per .5u (was 1.5 Burn per .5u)
  • Epinephrine now heals 1 Burn & 1 Brute per .5u (was .5 for each per .5u)
  • Kelotane now heals .5 Burn per .5u (was .33 Burn per .5u)
  • Omnizine now heals 3 Burn, Toxin, Airloss, and Brute per .5u (was 2 per .5u)
  • Lacerinol now heals 4 Slash per .5u (was 3 per .5u)
  • Bruizine now heals 4 Blunt per .5u (was 3.5 per .5u)

EDIT: Final values for applicables have been reduced by 5.

TODO

  • Cherry-pick Medical changes merged in Goobstation


Breaking changes

Should values be overtuned, they can be reduced in a future PR or before this PR is merged.

Changelog

🆑

  • tweak: Increased applicable medication heal values.
  • tweak: Increased stack size of applicable medications.
  • tweak: Slightly increased dylovene, burn, and brute chemicals heal values.
  • tweak: Decreased Medical item application time from 3s to 2s

* Update applicable heal values

* Reduced Healing Item DoAfter Delay from 3s to 2s

* Advanced brute meds were a bit overtuned. Buffed bloodpack bloodloss heal amount.

* Buff max stack amount for applicables and prices accordingly.

* Stack amounts were overtuned, reduced down to 15 max stack. Increased caustic healing on ointment.

* Slight buffs to burn chems, brute chems, and dylovene.

* Reduced bloodpack heal amount, was overtuned.
@Tmanzxd Tmanzxd changed the title Buff Medical due to Shitmed Changes (#914) Buff Medical due to Shitmed Changes Cherry-pick Nov 20, 2024
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Nov 20, 2024
@SimpleStation14 SimpleStation14 changed the title Buff Medical due to Shitmed Changes Cherry-pick Buff Medical Due to Shitmed Changes Cherry-Pick Nov 20, 2024
Copy link
Contributor

@sleepyyapril sleepyyapril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also highly consider changing cryo to be better, especially in terms of oppo.
Also, test fails are valid. I like the changes, but do fix the fails.

- type: StackPrice
price: 20
price: 40 #Was 20, Buffed due to limb damage changes (Goobstation)
Copy link
Contributor

@sleepyyapril sleepyyapril Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put it to 50? Sutures are rare and hard to get outside of getting logi to buy you 30 of them. It's only fair, given the surgery's ability to remove most old "difficult to heal" damage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would increase the sale value which is the problem we're having with the test fails rn.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would increase the sale value which is the problem we're having with the test fails rn.

That isn't a massive concern though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, but a crate for 3 advanced kits costs $2k with the updates. I think that should be fine.

@@ -43,7 +43,7 @@
- !type:HealthChange
damage:
types:
Poison: -1
Poison: -1.5 # Was 1, Slight Buff as it should heal for half the amount as Dip or Stelli(GoobStation)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps look into buffing diphenhydramine and stelli by 1.5-2x? Considering that replacing a liver (incredibly easy) now heals it instantly, you have to think about either nerfing that or changing to match.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current state of livers magically healing all poison damage is not intended to be the norm, just a funny and easy replacement for dialysis/blood pumps while i figure out how to deal with the procedures that would depend on a static structure (IV drips, dialysis, respirators, pumps, etc).

But a buff would probably be in order anyway since they will be as efficient as having tend wounds for those specific damage types.

Copy link
Contributor Author

@Tmanzxd Tmanzxd Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diphenhydramine Heals 90 poison per 15u, Stellibinnin Heals 96 poison per 15u. I don't think a buff should be necessary for those at the time being.

Signed-off-by: sleepyyapril <[email protected]>
Signed-off-by: sleepyyapril <[email protected]>
Signed-off-by: sleepyyapril <[email protected]>
@FoxxoTrystan FoxxoTrystan added the Priority: 2-High Needs to be resolved as soon as possible label Nov 21, 2024
@FoxxoTrystan FoxxoTrystan requested review from a team, VMSolidus, Aidenkrz, FoxxoTrystan, Remuchi, DEATHB4DEFEAT, Peptide90 and Pspritechologist and removed request for a team November 21, 2024 15:43
@github-actions github-actions bot added Status: Needs Review Someone please review this labels Nov 21, 2024
@FoxxoTrystan FoxxoTrystan added Size: 4-Small For small issues/PRs Type: Balancing Balancing some feature labels Nov 21, 2024
@Remuchi
Copy link
Contributor

Remuchi commented Nov 22, 2024

To me, this change seems a bit too radical. Buffing most medical items three times (somewhere even 6-7 times) makes them overtuned.

It would take 34 bruise packs to heal someone with 170 Blunt
It used to be the same before newmed.

Medical items are sort of "last resort" of you really have no chemicals on the station OR the person is already dead and you have to get the damage below 200 so you can revive them and start applying chems.
I'd advice that now it's even less need for medical items - since you can just threat wounds with surgery if the person is above 200 damage and that's it.

@Tmanzxd
Copy link
Contributor Author

Tmanzxd commented Nov 22, 2024

Treat wounds surgery only heals 5 per DoAfter currently and I've had situations on Goobstation and Grimbly Station where I've had to treat people with 500+ damage spread out across their limbs. Even with the buffs, chems, and surgery this is a time consuming process.

@Remuchi
Copy link
Contributor

Remuchi commented Nov 22, 2024

Saving someone beyond 300 damage SHOULD BE time consuming process. Either that or toss them in cryo with whatever works on dead people and hope for the best.

@Tmanzxd
Copy link
Contributor Author

Tmanzxd commented Nov 22, 2024

Even with the buffs this would be a time consuming process yes. Cryo I didn't change at all because it's even more useful now. This is purely to make medications reflect their SS13 counterpart.

If the values are overtuned when compared to their SS13 counterpart they can be reduced before merge.

@gluesniffler
Copy link
Contributor

Saving someone beyond 300 damage SHOULD BE time consuming process. Either that or toss them in cryo with whatever works on dead people and hope for the best.

Personally I think trying to minmax balance at this point is a huge waste of time, especially when we've got pain and other things on the horizon that will absolutely throw any idea of "balancing" or "should" out of the window for 14.

@sleepyyapril
Copy link
Contributor

Saving someone beyond 300 damage SHOULD BE time consuming process. Either that or toss them in cryo with whatever works on dead people and hope for the best.

Saving someone beyond 300 damage SHOULD BE time consuming process. Either that or toss them in cryo with whatever works on dead people and hope for the best.

Funnily enough, I'm fairly sure cryo (at least oppo) is broken. It returns you to rotting too quick for it to be not a bug.

@Tmanzxd
Copy link
Contributor Author

Tmanzxd commented Nov 22, 2024

If anything I'm looking at the values when compared to SS13 rn, the current values I have heal 5 more than their SS13 counterpart. But I have seen people walk into medbay with >100~400 burn damage on each of their limbs. So this is a call by the maintainers.

@Tmanzxd
Copy link
Contributor Author

Tmanzxd commented Nov 22, 2024

Talked to others about it, gonna reduce the values by 5 to reflect their SS13 counterpart more so its properly tuned.

reduced values to fit their SS13 counterpart.

Signed-off-by: Tmanzxd <[email protected]>
@Tmanzxd
Copy link
Contributor Author

Tmanzxd commented Nov 22, 2024

There we go, that should fix the tuning.

@VMSolidus VMSolidus merged commit b431d24 into Simple-Station:master Nov 22, 2024
11 checks passed
@Tmanzxd Tmanzxd deleted the BuffMed branch November 22, 2024 21:53
sleepyyapril pushed a commit to sleepyyapril/Einstein-Engines that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this Type: Balancing Balancing some feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants