Beacons #1193
Closed
Beacons #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use nav beacon locations for announcements * :thumbs_up:
github-actions
bot
added
Changes: C#
VMSolidus
approved these changes
Nov 8, 2024
Aidenkrz
approved these changes
Nov 8, 2024
Aidenkrz
requested changes
Nov 8, 2024
|
I'm unable to repair the Server NavMapSystem, since it looks like this was either a bad merge, and/or it is missing a dependency PR. |
|
I can easily fix this, one moment. |
Aidenkrz
requested changes
Nov 8, 2024
| [Dependency] private readonly ITileDefinitionManager _tileDefManager = default!; | ||
| [Dependency] private readonly TransformSystem _transform = default!; | ||
|
|
||
| private EntityQuery<PhysicsComponent> _physicsQuery; |
There was a problem hiding this comment.
your missing a using, Robust.Shared.Physics.Components;
There was a problem hiding this comment.
No longer relevant
There was a problem hiding this comment.
"no longer relevant" look at your checks
There was a problem hiding this comment.
Oh, somehow relevant? I moved back to the commit with EE's stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes carp rifts, nuke arming, and emergency shuttle to use readable locations.
I don't know EE codebase as well, so please request changes on anything I shouldn't have changed!
Media
Changelog
nah