Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix This Stupid Behavior #1177

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Nov 2, 2024

image

I don't need to explain this further. The image speaks for itself.

🆑

  • tweak: Cargo Technicians and Salvage Techs can now process cargo orders. You don't need to smash the fucking LO Locker with a pickaxe anymore.

@github-actions github-actions bot added the Changes: YML Changes any yml files label Nov 2, 2024
@FoxxoTrystan FoxxoTrystan requested review from a team, Aidenkrz, FoxxoTrystan, Remuchi, DEATHB4DEFEAT, Peptide90, Pspritechologist and OldDanceJacket and removed request for a team November 2, 2024 19:17
@github-actions github-actions bot added Status: Needs Review Someone please review this labels Nov 2, 2024
@FoxxoTrystan FoxxoTrystan added Priority: 2-High Needs to be resolved as soon as possible Size: 5-Very Small For especially small issues/PRs labels Nov 2, 2024
@FoxxoTrystan
Copy link
Contributor

At least gives this a correct changlog and information.

@VMSolidus
Copy link
Member Author

At least gives this a correct changlog and information.

Done

@FoxxoTrystan FoxxoTrystan added the Status: Needs Discussion Must be discussed label Nov 2, 2024
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personnaly im good with this.

Tho some orders, like security things should require LO/Warden approval, but thats depands on the code is done.

Because its way easy to just get stuff and then break it.

@VMSolidus
Copy link
Member Author

Personnaly im good with this.

Tho some orders, like security things should require LO/Warden approval, but thats depands on the code is done.

Because its way easy to just get stuff and then break it.

I want to start transitioning maps away from having the ATS, because it'll help alleviate some of the "Cargo/Salvage Toxicity". Saltern is a model for this. If a Station has the TradeStationComponent, and Cargo Pallets, cargo will work just fine on it without the ATS at all. My reasoning is such:

image

image

@VMSolidus VMSolidus merged commit b7de623 into Simple-Station:master Nov 2, 2024
20 checks passed
@DangerRevolution
Copy link
Contributor

DangerRevolution commented Nov 3, 2024

Why aren't LRP changes like #1171 and this #1177 and your desire to remove ATS not kept to Deepstation and instead PRed here? EE is designed to be an MRP-HRP fork.

@FoxxoTrystan
Copy link
Contributor

Personnaly im good with this.
Tho some orders, like security things should require LO/Warden approval, but thats depands on the code is done.
Because its way easy to just get stuff and then break it.

I want to start transitioning maps away from having the ATS, because it'll help alleviate some of the "Cargo/Salvage Toxicity". Saltern is a model for this. If a Station has the TradeStationComponent, and Cargo Pallets, cargo will work just fine on it without the ATS at all. My reasoning is such:

image

image

Im not a fan of this at all.
This makes cargo just... not cargo really.

Theres a CVar regarding ATS/Cargo Shuttle, lets servers uses this instead.

@VMSolidus
Copy link
Member Author

Why aren't LRP changes like #1171 and this #1177 and your desire to remove ATS not kept to Deepstation and instead PRed here? EE is designed to be an MRP-HRP fork.

How about you explain what your thought process is behind this? Because in my mind, all our damn servers are Lowpop, and on Lowpop servers, every fucking round, salvage takes a pickaxe to the LO Office to steal his ID and digiboard so that they can hoard everything in the salvage ship. How the fuck is that not NRP?

@Mnemotechnician
Copy link
Contributor

Mnemotechnician commented Nov 3, 2024

How about you explain what your thought process is behind this? Because in my mind, all our damn servers are Lowpop, and on Lowpop servers, every fucking round, salvage takes a pickaxe to the LO Office to steal his ID and digiboard so that they can hoard everything in the salvage ship. How the fuck is that not

"All our damn servers"? Please, let me interject for a second and recite one of the core ideals of Einstein-Engines...

No official servers will ever be made for Einstein-Engines.

In order to prevent a potential conflict of interest, we will never open any server directly using the Einstein Engines codebase itself. Any server claiming to be an official representation of this fork is not endorsed in any way by this organization. We however would like to invite anyone wishing to create a server to make a fork of Einstein Engines.

Okay, I'm not insane, and EE still doesn't officially have any official servers, and is still supposed to provide the best experience regardless of what is the average population on deepstation.

Back to the point,

every fucking round, salvage takes a pickaxe to the LO Office to steal his ID and digiboard so that they can hoard everything in the salvage ship. How the fuck is that not NRP?

It IS NRP and a bad example of powergaming. if salvage does that, the admins should take action. Send a centcom inspector, blow up their ship, bwoink the salvagers if it is a consistent issue. Roleban if they do not change. We should NOT, by any means NOT be endorsing this NRP behavior. Encouraging NRP/LRP behavior is what we all hated about wizden, we shouldn't do that ourselves.

@VMSolidus
Copy link
Member Author

image

Hey look, an untouched LO office post this update.

@Mnemotechnician
Copy link
Contributor

Hey look, an untouched LO office post this update.

Lets not repeat the mistake of wizden and try to have a constructive discussion instead.

@DangerRevolution
Copy link
Contributor

Because in my mind, all our damn servers are Lowpop

EE doesn't host servers?

And several servers (Goob 2, Floof, Lost Paradise) aren't lowpop either.

And lowpop provisions for this by giving Cargo Techs orders access on skeleton crew to negate this problem.

and on Lowpop servers, every fucking round, salvage takes a pickaxe to the LO Office to steal his ID and digiboard so that they can hoard everything in the salvage ship. How the fuck is that not NRP?

It's NRP, which isn't your concern (EE doesn't host servers), it's the concern of the maintainers of the downstreams which are lowpop and allow for LRP behaviour.

A better solution could be... removing all the hour requirements for roles (and letting downstreams set them up) so it doesn't take 30-40 hours of gameplay for command roles with orders access (excluding CT which has orders on lowpop)

@Mnemotechnician
Copy link
Contributor

And lowpop provisions for this by giving Cargo Techs orders access on skeleton crew to negate this problem.

I agree with this, we can add Orders to the list of cargo technicians' and salvagers' ExtendedAccess. That would both solve the issue that caused this spite PR, and adhere to the higher roleplay standards. Engineers, for instance, already get atmos access in low-pop for a similar reason: so they don't have to break into atmos to save the station from suffocating.

Mnemotechnician added a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Mnemotechnician added a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Size: 5-Very Small For especially small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants