Show Language Names In Chat #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: C#
VMSolidus
requested review from
Aidenkrz,
FoxxoTrystan,
Remuchi,
DEATHB4DEFEAT,
Peptide90,
Pspritechologist and
OldDanceJacket
Remuchi
previously requested changes
Oct 29, 2024
Remuchi
added
Size: 4-Small
|
Might just be me, but this isn't readable in the slightest. |
|
Dont do this, this will bloat up chat. |
|
I planned to use this instead. |
stellar-novas
requested changes
Oct 29, 2024
Co-authored-by: Remuchi <[email protected]> Signed-off-by: VMSolidus <[email protected]>
|
I agree with the others, I don't like the visual of it being next to the name and it will bloat chat. @FoxxoTrystan had a good idea. |
|
If anything, this should be togglable. Could add a toggle button to the filters menu, or elsewhere, and move the related code to client-side. |
Peptide90
approved these changes
Nov 1, 2024
OldDanceJacket
approved these changes
Nov 2, 2024
|
I did this simply because we had a similar system before switching to your build. And for example, the general galactic language can be omitted for display. As for me, it is extremely convenient if someone does not speak the general language. |
|
Yay our build now being used 😆 |
Closed
VMSolidus
pushed a commit
to VMSolidus/Einstein-Engines
that referenced
this pull request
Nov 8, 2024
sleepyyapril
added a commit
to sleepyyapril/Einstein-Engines
that referenced
this pull request
Nov 14, 2024
This reverts commit 3209838.
VMSolidus
pushed a commit
that referenced
this pull request
Nov 29, 2024
# Description Re-enables language font and colors showing up in chat messages. The language font/colors were bugged after adding language names in chat (#1165) I also overhauled the format for chat messages to be more aesthetically pleasing, and made sure chat bubbles use the language color/font. ## Media **Nekomimetic**   **Bubblish**   **Tau-Ceti Basic (Default Language)**   **Rootspeak**   ## Changelog :cl: Skubman - fix: Language colors and fonts will show up in text messages again, both on in-person messages and on the radio. - tweak: The text on chat bubbles now uses the color and font of the language being spoken. - tweak: The language prefix before the name on chat messages now uses the language's color.
7 tasks
Fansana
pushed a commit
to Fansana/floofstation1
that referenced
this pull request
Dec 15, 2024
# Description Re-enables language font and colors showing up in chat messages. The language font/colors were bugged after adding language names in chat (Simple-Station/Einstein-Engines#1165) I also overhauled the format for chat messages to be more aesthetically pleasing, and made sure chat bubbles use the language color/font. ## Media **Nekomimetic**   **Bubblish**   **Tau-Ceti Basic (Default Language)**   **Rootspeak**   ## Changelog :cl: Skubman - fix: Language colors and fonts will show up in text messages again, both on in-person messages and on the radio. - tweak: The text on chat bubbles now uses the color and font of the language being spoken. - tweak: The language prefix before the name on chat messages now uses the language's color. (cherry picked from commit 1a9763528a9b15f11f474a2fa7ecfdde98aa9a15)
Pspritechologist
pushed a commit
to Simple-Station/Parkstation-Friendly-Chainsaw
that referenced
this pull request
Dec 21, 2024
# Description Re-enables language font and colors showing up in chat messages. The language font/colors were bugged after adding language names in chat (Simple-Station/Einstein-Engines#1165) I also overhauled the format for chat messages to be more aesthetically pleasing, and made sure chat bubbles use the language color/font. ## Media **Nekomimetic**   **Bubblish**   **Tau-Ceti Basic (Default Language)**   **Rootspeak**   ## Changelog :cl: Skubman - fix: Language colors and fonts will show up in text messages again, both on in-person messages and on the radio. - tweak: The text on chat bubbles now uses the color and font of the language being spoken. - tweak: The language prefix before the name on chat messages now uses the language's color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of Lost-Paradise-Project/Lost-Paradise#288 from Lost Paradise. This feature makes it so that the language you are speaking is shown in chat, preventing any confusion for players about what it is being spoken.
Media
Changelog
🆑