Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loadouts V4 #1164

Merged
merged 53 commits into from
Nov 25, 2024
Merged

Loadouts V4 #1164

merged 53 commits into from
Nov 25, 2024

Conversation

DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Oct 29, 2024 •
edited by VMSolidus
Loading

Description

TODO

  • Custom name/desc/color tint, toggleable individually per-loadout
    • Fix them not changing correctly between profiles in-editor
    • Preview colors in the lobby
    • Allow the users to null the color themselves (and default it to such)
    • Pick what should be allowed to be recolored
  • Guidebook links
    • Make an example
  • Special components for loadouts
  • Heirlooms
    • Pick what should have heirlooms
  • Decimate lag
  • Fix live character preview
  • Maybe do characters per job
    • Rethink unusable

Media

2024-10-29_23-26-56.mp4

Changelog

🆑

  • add: Players can set custom names, descriptions, and color tints for their loadout items
  • add: Certain loadouts may have Guidebook pages shown in the editor
  • add: Players can pick a list of loadout items to have one randomly be their family heirloom for a mood bonus or deficit if they are carrying it
  • fix: Loadouts have almost as little lag as possible (hopefully none)
  • fix: Everything properly updates your character editor's live preview

@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 3-Medium Needs to be resolved at some point Type: Feature Creation of or significant changes to a feature Type: Bug [Un]intentional issue with something Type: Cleanup Like Rework but small labels Oct 29, 2024
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: Documentation Changes any xml or md files Changes: YML Changes any yml files labels Oct 29, 2024
@SimpleStation14 SimpleStation14 changed the title Loadouts v4 Loadouts V4 Oct 29, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as draft October 29, 2024 01:33
@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an RSI label Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

RSI Diff Bot; head commit 9659956 merging into 8739096
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Fun/spraycans.rsi

State Old New Status
spray_cap Removed
clown-inhand-left Added
clown-inhand-right Added
spray-inhand-left Added
spray-inhand-right Added

Edit: diff updated after 9659956

@DEATHB4DEFEAT
Copy link
Member Author

24 -> 71 files :goberserk:

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Nov 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@FoxxoTrystan FoxxoTrystan requested review from a team, VMSolidus, Aidenkrz, FoxxoTrystan, Remuchi, Peptide90, Pspritechologist and OldDanceJacket and removed request for a team November 21, 2024 15:58
@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Nov 25, 2024
@VMSolidus VMSolidus merged commit f046306 into Simple-Station:master Nov 25, 2024
9 of 10 checks passed
BL02DL pushed a commit to BL02DL/BL-CORP-EE that referenced this pull request Nov 25, 2024
@SimpleStation14
Automatic Changelog Update (Simple-Station#1164)
57917a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gluesniffler gluesniffler gluesniffler left review comments

@OldDanceJacket OldDanceJacket OldDanceJacket approved these changes

@VMSolidus VMSolidus VMSolidus approved these changes

@Aidenkrz Aidenkrz Awaiting requested review from Aidenkrz Aidenkrz was automatically assigned from Simple-Station/ee-writers

@FoxxoTrystan FoxxoTrystan Awaiting requested review from FoxxoTrystan FoxxoTrystan was automatically assigned from Simple-Station/ee-writers

@Remuchi Remuchi Awaiting requested review from Remuchi Remuchi was automatically assigned from Simple-Station/ee-writers

@Peptide90 Peptide90 Awaiting requested review from Peptide90 Peptide90 was automatically assigned from Simple-Station/ee-writers

@Pspritechologist Pspritechologist Awaiting requested review from Pspritechologist Pspritechologist was automatically assigned from Simple-Station/ee-writers

Assignees

@DEATHB4DEFEAT DEATHB4DEFEAT

Labels
Changes: C# Changes any cs files Changes: Config Changes any configuration files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: UI Changes any XAML files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 2-Large For large issues/PRs Status: Needs Review Someone please review this Status: Requires This requires something else to be done before being resolved Type: Bug [Un]intentional issue with something Type: Cleanup Like Rework but small Type: Feature Creation of or significant changes to a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DEATHB4DEFEAT @VMSolidus @Pspritechologist @OldDanceJacket @gluesniffler @metalgearsloth