Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosin Rework (#1391) Port over From Frontier #1148

Closed

Conversation

VividPups
Copy link

About the PR

This is a port over from another server frontier to allow guns to have melee attacks with it
new-frontiers-14/frontier-station-14#1391

Description

Rework the Mosin to allow Melee now, Butcher and Throwing

Why / Balance

Mosin is regarded as one of the worst weapons in the game, to the point that nearly no one uses it. Countless times, people have asked/requested to remove the bayonet from the Mosin sprite or give it the ability to be used as a melee weapon. Because Upstream changed/removed the coding for melee/range weapons, it is a bit funky, but I feel like it isn't that bad to the point where I would say it's terrible.

  1. Lower the Ammo capacity by 10 -> 5. Five is the IRL Standard ammo capacity for the mosin
  2. Raised the Firing rate to 1
  3. Melee and Throw damage is the same.
    Attack rate of .85
    - Piercing 10 (you are stabbing someone so it
    - Slash 5 (you are pulling the bayonet out so it causes bleeding

How to test

Spawn in the Mosin. Shooting the rifle will now be Right click, where a "pinpoint" melee attack is left click however when the Ammo for the mosin runs dry the right click turns into a thrust attack

Media

- [X] this PR does not require an in-game showcase

Changelog

Turns out the Bayonet had a sheath on it

🆑

  • tweak: Turns out Mosin's Bayonet had a Sheath on it

* Testing?

Mosin rework

* Update snipers.yml

* Update 2

* update 3

* Update snipers.yml

* Update snipers.yml

* Dumb updates

updates do be dumb sometimes

* WOULD THIS WORK?

FUCK FUCK FU
@github-actions github-actions bot added the Changes: YML Changes any yml files label Oct 26, 2024
@SimpleStation14 SimpleStation14 changed the title Mosin Rework (#1391) port over from Frontier Mosin Rework (#1391) Port over From Frontier Oct 26, 2024
@VividPups
Copy link
Author

I just remember something, the PR for the code changes itself to allow it was in this pr not in the mosin PR

new-frontiers-14/frontier-station-14#1400

@FoxxoTrystan FoxxoTrystan requested review from a team, VMSolidus, Aidenkrz, FoxxoTrystan, Remuchi, DEATHB4DEFEAT, Peptide90 and Pspritechologist and removed request for a team October 27, 2024 12:56
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 27, 2024
@FoxxoTrystan FoxxoTrystan added Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Type: Port Brings something to here from another codebase labels Oct 27, 2024
@VMSolidus
Copy link
Member

I just remember something, the PR for the code changes itself to allow it was in this pr not in the mosin PR

new-frontiers-14/frontier-station-14#1400

If your PR requires another PR to work properly(Such as the bugfixes needed there), you're going to need to cherrypick it too in this.

@VividPups
Copy link
Author

I will do when I'm not in the hospital

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Dec 12, 2024
@VividPups VividPups closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Merge Conflict FIX YOUR PR AAAGH Status: Needs Review Someone please review this Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants