Skip to content

Commit

Permalink
Mirror: Fix anomaly decay logs (#227)
Browse files Browse the repository at this point in the history
## Mirror of PR #26180: [Fix anomaly decay
logs](space-wizards/space-station-14#26180) from
<img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `d8a7b33b43cd9b0e241dc189653cbd4cf4c49086`

PR opened by <img
src="https://avatars.githubusercontent.com/u/27449516?v=4"
width="16"/><a href="https://github.com/LordCarve"> LordCarve</a> at
2024-03-16 17:05:24 UTC

---

PR changed 1 files with 3 additions and 2 deletions.

The PR had the following labels:
- Status: Needs Review


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> - Decayed Anomalies leave log with `LogImpact.Low` (down from
`LogImpact.Extreme` and being misreported as having gone supercritical)
> Reason: Admin Logs severity usually means how much of admin attention
this requires. A decayed anomaly does not require any Admin attention
and is essentially just a convenience note.
> 
> - Swapped `LogImpact`s of supercritical event starting and finishing.
> Reason: When an anomaly starts going supercritical it leaves a log
with `LogImpact.High`, but when it finishes the animation it leaves a
log with `LogImpact.Extreme`. This seems inconsistent to me, because the
moment anomaly starts going supercritical seems to demand more Admin
attention than an "it had already happened"-style report. After this
change, a supercritical anomaly will still always leave at least one
`LogImpact.Extreme` admin log, so from reporting perspective it should
be conveying the same message;, but from "immediate responder"
perspective Admins get the more-important `Extreme` log sooner (as the
supercritical event starts happening, rather than after it had already
finished).
> 
> Resolves #26122
> 
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> Bugfix.
> 
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> Anomalies ending still leave multiple logs. This is beyond the scope
of this PR.
> But at least now it won't spam the `LogImpact.Extreme` category.
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
![image](https://github.com/space-wizards/space-station-14/assets/27449516/09ddfd79-a872-4be2-8ba7-16619b63835b)
> 
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> 🆑
> ADMIN
> - fix: Decayed anomalies no longer show as having gone supercritical
in logs.


</details>

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <[email protected]>
  • Loading branch information
SimpleStation14 and VMSolidus authored May 29, 2024
1 parent 75106b3 commit ec3986b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Content.Shared/Anomaly/SharedAnomalySystem.cs
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public void StartSupercriticalEvent(EntityUid uid)
if (HasComp<AnomalySupercriticalComponent>(uid))
return;

AdminLog.Add(LogType.Anomaly, LogImpact.High, $"Anomaly {ToPrettyString(uid)} began to go supercritical.");
AdminLog.Add(LogType.Anomaly, LogImpact.Extreme, $"Anomaly {ToPrettyString(uid)} began to go supercritical.");
if (_net.IsServer)
Log.Info($"Anomaly is going supercritical. Entity: {ToPrettyString(uid)}");

Expand Down

0 comments on commit ec3986b

Please sign in to comment.