Skip to content

Commit

Permalink
Make Non-Verbal Langs Not Play Speech (#1448)
Browse files Browse the repository at this point in the history
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Makes non-verbal languages no longer emit speech sounds. Ported from
[Goob-Station-MRP#29](Goob-Station/Goob-Station-MRP#29)
at @angelofallars's request.

---


<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>


![PR
Example](https://github.com/user-attachments/assets/8be6b705-eff7-4e2e-ab53-5648dccfc7eb)


</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- tweak: Languages that don't require speech (I.E. Sign Language) will
no longer play speech sounds.

---------

Signed-off-by: RadsammyT <[email protected]>
Co-authored-by: Skubman <[email protected]>
Co-authored-by: flyingkarii <[email protected]>
Co-authored-by: sleepyyapril <[email protected]>
Co-authored-by: SimpleStation Changelogs <[email protected]>
  • Loading branch information
5 people authored Jan 7, 2025
1 parent f6dec10 commit 990a57c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Content.Server/Speech/SpeechNoiseSystem.cs
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public override void Initialize()

private void OnEntitySpoke(EntityUid uid, SpeechComponent component, EntitySpokeEvent args)
{
if (component.SpeechSounds == null)
if (component.SpeechSounds == null || !args.Language.SpeechOverride.RequireSpeech)
return;

var currentTime = _gameTiming.CurTime;
Expand Down

0 comments on commit 990a57c

Please sign in to comment.