Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dependency injection #38

Merged

Conversation

iampeterbanjo
Copy link
Contributor

addresses #31

@SimonWaldherr
Copy link
Owner

thanks for your pr, can you please add your example to the readme file.
what should go Shellrun do??

@iampeterbanjo
Copy link
Contributor Author

thanks - i've updated the reame.

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@SimonWaldherr
Copy link
Owner

Please think about whether you want to consider a rebase to cleanup the commit history: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

@SimonWaldherr SimonWaldherr merged commit bb5538a into SimonWaldherr:master Oct 15, 2018
@iampeterbanjo
Copy link
Contributor Author

thanks. i rebased it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants